[SelectableEventLoop] SR-15872; Save allocations when appending task #2046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
force-pushed
the
ff-tasks-are-crazy
branch
from
67d682f to
be9c305
Compare
fabianfett
changed the title
glbrntt
reviewed
Feb 17, 2022
fabianfett
force-pushed
the
ff-tasks-are-crazy
branch
from
1ceb279 to
fd5207c
Compare
fabianfett
force-pushed
the
ff-tasks-are-crazy
branch
2 times, most recently
from
d889ab8 to
19c51d7
Compare
fabianfett
force-pushed
the
ff-tasks-are-crazy
branch
from
19c51d7 to
e6fc207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should probably wait for #2047, before we merge this one.
Motivation
Changes
[ScheduledTask]instead of[() -> Void]Result
Alternatives
We could create a struct that really only wraps the closure.