Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make package parameter of deep link command optional #847

Merged
merged 3 commits into from
Dec 11, 2024
Merged

fix: Make package parameter of deep link command optional #847

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
899e966
fix: make package of mobileDeepLink optional
fur0ut0 Dec 9, 2024
baa8b70
build: Bump up appium-adb
fur0ut0 Dec 10, 2024
1a5f998
docs: Add note of version
fur0ut0 Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ Start URI that may take users directly to the specific content in the app. Read
Name | Type | Required | Description | Example
--- | --- | --- | --- | ---
url | string | yes | The URL to start | theapp://login/
package | string | yes | The name of the package to start the URI with | 'com.mycompany'
package | string | no | The name of the package to start the URI with | 'com.mycompany'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also mention the minimum uia2 driver version where this argument become optional

waitForLaunch | boolean | no | If `false` then ADB won't wait for the started activity to return the control. `true` by default | false

### mobile: startLogsBroadcast
Expand Down
2 changes: 1 addition & 1 deletion lib/commands/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ export interface DeepLinkOpts {
/**
* The name of the package to start the URI with.
*/
package: string;
package?: string;
/**
* If `false` then adb won't wait for the started activity to return the control.
* @defaultValue true
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
"singleQuote": true
},
"dependencies": {
"appium-adb": "^12.7.0",
"appium-adb": "^12.7.3",
"appium-android-driver": "^9.14.2",
"appium-uiautomator2-server": "^7.0.24",
"asyncbox": "^3.0.0",
Expand Down
Loading