Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make package parameter of deep link command optional #847

Merged

Conversation

fur0ut0
Copy link
Contributor

@fur0ut0 fur0ut0 commented Dec 10, 2024

pkg parameter of startUri() becomes optional from appium-adb 12.7.3 by appium/appium-adb#776.

This PR follows this change by making package parameter of mobileDeepLink() optional.

@fur0ut0 fur0ut0 changed the title fix: make package parameter of deep link command optional fix: Make package parameter of deep link command optional Dec 10, 2024
README.md Outdated
@@ -431,7 +431,7 @@ Start URI that may take users directly to the specific content in the app. Read
Name | Type | Required | Description | Example
--- | --- | --- | --- | ---
url | string | yes | The URL to start | theapp://login/
package | string | yes | The name of the package to start the URI with | 'com.mycompany'
package | string | no | The name of the package to start the URI with | 'com.mycompany'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also mention the minimum uia2 driver version where this argument become optional

@mykola-mokhnach mykola-mokhnach merged commit ddc7477 into appium:master Dec 11, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 11, 2024
## [3.9.3](v3.9.2...v3.9.3) (2024-12-11)

### Bug Fixes

* Make package parameter of deep link command optional ([#847](#847)) ([ddc7477](ddc7477))
Copy link

🎉 This PR is included in version 3.9.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants