-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernization 3 #161
Merged
Merged
Modernization 3 #161
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d002545
update dependencies
phryneas 0e22939
update "Run in Studio" link generation
phryneas 3f7b80c
lockfile
phryneas 64b76e8
switch back to old uri (they work if you are logged in)
phryneas c06d984
changeset
phryneas 8ee3570
run E2E tests in CI
phryneas 1d50a38
start workflow
phryneas 17b8e5a
install deps on CI
phryneas 7a76a64
sudo?
phryneas 6c675d6
handle shell error code correctly
phryneas eb45414
embed fake api key in test runner itself
phryneas 0423064
write env file
phryneas File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"vscode-apollo": patch | ||
--- | ||
|
||
Only show "Run in Studio" gutter action for local graphs if an endpoint is configured. | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
--- | ||
"vscode-apollo": patch | ||
--- | ||
|
||
Modernization | ||
|
||
- update `minimatch` and `lz-string` | ||
- drop `await-to-js`, `resolve-from`, `sha.js` | ||
- drop `query-string` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"vscode-apollo": patch | ||
--- | ||
|
||
Fix a bug where the "Run in Studio" button would link to a Studio Graph instead of Explorer for local projects. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure.. it seems like a good idea, but might someone get use from a link to explorer that doesn't fill in the endpoint?
My gut says removing this is the right thing, but I'd love a second opinion.