Modernization 3 #161
Merged
Modernization 3 #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phryneas
commented
Aug 2, 2024
| @@ -28,7 +28,7 @@ import { | |||
| DiagnosticSeverity, | |||
| } from "vscode-languageserver/node"; | |||
| import LZString from "lz-string"; | |||
| import { stringifyUrl } from "query-string"; | |||
There was a problem hiding this comment.
New versions of "query-string" are ESM only and I really don't want to touch the build process of the Extension right now.
phryneas
commented
Aug 2, 2024
| @@ -412,7 +412,7 @@ export class GraphQLClientProject extends GraphQLProject { | |||
| this.frontendUrlRoot ?? "https://studio.apollographql.com"; | |||
|
|
|||
| const variant = this.config.variant; | |||
| const graphId = this.config.graph; | |||
| const graphId = this.studioGraphId; | |||
There was a problem hiding this comment.
If I have a config file like
module.exports = {
client: {
service: {
name: "localSchema",
localSchemaFile: "./starwarsSchema.graphql",
},
},
};
graphId would be localSchema - of course, linking to studio for that is kinda useless, but that's exactly what the extension did until now.
phryneas
force-pushed
the
pr/modernization-3
branch
from
fedd51f to
6c675d6
Compare
phryneas
commented
Aug 2, 2024
| "vscode-apollo": patch | ||
| --- | ||
|
|
||
| Only show "Run in Studio" gutter action for local graphs if an endpoint is configured. |
There was a problem hiding this comment.
I'm not 100% sure.. it seems like a good idea, but might someone get use from a link to explorer that doesn't fill in the endpoint?
My gut says removing this is the right thing, but I'd love a second opinion.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.