feat(binstall): don't require terminal reload #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EverlastingBugstopper
requested review from
JakeDawkins and
lrlna
as code owners
EverlastingBugstopper
added
the
feature 🎉
JakeDawkins
approved these changes
Mar 1, 2021
| // re-source their shell. the binary will be available for | ||
| // execution immediately after installation. | ||
| let _ = Command::new(shell.name()) | ||
| .arg("-c") |
There was a problem hiding this comment.
Ooh, neato! I didn't know about this
-c take first argument as a command to execute
lrlna
approved these changes
Mar 2, 2021
EverlastingBugstopper
added a commit
that referenced
this pull request
Mar 31, 2021
This reverts commit 7fb6f21.
EverlastingBugstopper
added a commit
that referenced
this pull request
Mar 31, 2021
|
this did not work and the commit was reverted in #406 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #212 - windows doesn't need any changes since there aren't really "shell startup scripts", we're just directly modifying the PATH in that case. *nix installers just call the
-c source ~/.rover/envcommand and call it a day :)