Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(installer): dont require reloading terminal #212

Closed
EverlastingBugstopper opened this issue Jan 29, 2021 · 0 comments · Fixed by #318
Closed

feat(installer): dont require reloading terminal #212

EverlastingBugstopper opened this issue Jan 29, 2021 · 0 comments · Fixed by #318
Assignees
@EverlastingBugstopper
Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Milestone
March 9

Comments

@EverlastingBugstopper
Copy link
Contributor

we currently set the PATH in the shell startup scripts, but we should set the PATH in the current shell as well so folks don't have to exec bash to run their startup script and get access to Rover.

def a nice to have but shouldn't be too difficult to implement!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EverlastingBugstopper EverlastingBugstopper

Labels
feature 🎉 new commands, flags, functionality, and improved error messages
Projects
None yet
Milestone
March 9
Development

Successfully merging a pull request may close this issue.

feat(binstall): don't require terminal reload apollographql/rover
2 participants
@lrlna @EverlastingBugstopper