Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): Replicate custom histograms CHANGELOG to v1.46.0. #5351

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

abernix
Copy link
Member

@abernix abernix commented Jun 5, 2024

In theory https://github.com/apollographql/router/releases/tag/v1.40.0 was the first version in which this was fixed, but we don't recommend running that version for the reasons that are already noted in the CHANGELOG.md.

Therefore, the first version that we recommend using to utilize custom historgrams is https://github.com/apollographql/router/releases/tag/v1.46.0. This updates the CHANGELOG.md to signal that with a note and a duplication of the original CHANGELOG entry.

Original Issue: #4543
Initial PR: #4572
Stabilizing PR: #4771

Copy link
Contributor

github-actions bot commented Jun 5, 2024

@abernix, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

@router-perf
Copy link

router-perf bot commented Jun 5, 2024

CI performance tests

  • step - Basic stress test that steps up the number of users over time
  • reload - Reload test over a long period of time at a constant rate of users
  • step-with-prometheus - A copy of the step test with the Prometheus metrics exporter enabled
  • events_without_dedup_callback - Stress test for events with a lot of users and deduplication DISABLED using callback mode
  • events - Stress test for events with a lot of users and deduplication ENABLED
  • events_without_dedup - Stress test for events with a lot of users and deduplication DISABLED
  • events_big_cap_high_rate_callback - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity using callback mode
  • xlarge-request - Stress test with 10 MB request payload
  • const - Basic stress test that runs with a constant number of users
  • events_big_cap_high_rate - Stress test for events with a lot of users, deduplication enabled and high rate event with a big queue capacity
  • step-jemalloc-tuning - Clone of the basic stress test for jemalloc tuning
  • xxlarge-request - Stress test with 100 MB request payload
  • demand-control-uninstrumented - A copy of the step test, but with demand control monitoring enabled
  • no-graphos - Basic stress test, no GraphOS.
  • events_callback - Stress test for events with a lot of users and deduplication ENABLED in callback mode
  • large-request - Stress test with a 1 MB request payload
  • demand-control-instrumented - A copy of the step test, but with demand control monitoring and metrics enabled

In theory v1.44.0 was the first version in which this was fixed, but we
don't recommend running that version for the reasons that are already noted
in the CHANGELOG.md.

Therefore, the first version that we recommend using to utilize custom
historgrams is v1.46.0.  This updates the CHANGELOG.md to signal that with a
note and a duplication of the original CHANGELOG entry.

Original Issue: #4543
Initial PR: #4572
Stabilizing PR: #4771
@abernix abernix force-pushed the abernix/changelog_tweak_for_4543 branch from 03b0ef8 to 85492c6 Compare June 5, 2024 15:36
@abernix abernix enabled auto-merge (squash) June 5, 2024 17:51
@abernix abernix merged commit 3d2269f into dev Jun 6, 2024
14 checks passed
@abernix abernix deleted the abernix/changelog_tweak_for_4543 branch June 6, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants