-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support of instruments in configuration for telemetry #4771
Conversation
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
Signed-off-by: Benjamin Coenen <[email protected]>
…g and with custom instruments it will be more compliant to use Vec for attributes Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
One thing that needs to be added are the config metrics in configuration/metrics.rs. It can use the same pattern as we did for spans. |
Signed-off-by: Benjamin Coenen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general this is looking good.
I think that the code very unit testable so would like to see the individual functions tested in each module.
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
I think
I was expecting the recommended attributes to appear on the standard instrument but there are none: Note also that the standard attributes do not correlate with the span standard attributes, so if we're sharing logic there then it'll add the wrong attributes. |
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Co-authored-by: Gary Pennington <[email protected]>
In theory v1.44.0 was the first version in which this was fixed, but we don't recommend running that version for the reasons that are already noted in the CHANGELOG.md. Therefore, the first version that we recommend using to utilize custom historgrams is v1.46.0. This updates the CHANGELOG.md to signal that with a note and a duplication of the original CHANGELOG entry. Original Issue: #4543 Initial PR: #4572 Stabilizing PR: #4771
In theory v1.44.0 was the first version in which this was fixed, but we don't recommend running that version for the reasons that are already noted in the CHANGELOG.md. Therefore, the first version that we recommend using to utilize custom historgrams is v1.46.0. This updates the CHANGELOG.md to signal that with a note and a duplication of the original CHANGELOG entry. Original Issue: #4543 Initial PR: #4572 Stabilizing PR: #4771
Add support for custom and standard instruments through the configuration file. You'll be able to add your own custom metrics just using the configuration file. It can be conditional, get values from selectors like headers, context, body. And the metrics can have different types like
histogram
orcounter
.Example:
Documentation
Fixes #4319
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩