-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prep release: v1.33.0 #4046
Merged
Merged
prep release: v1.33.0 #4046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin Coenen <[email protected]>
CI performance tests
|
Signed-off-by: Benjamin Coenen <[email protected]>
Closed
garypen
requested changes
Oct 17, 2023
Co-authored-by: Gary Pennington <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
BrynCooke
approved these changes
Oct 17, 2023
garypen
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Features
Add
hasNext
to SupergraphRequest (Issue #4016)Coprocessors multi-part response support has been enhanced to include
hasNext
, allowing you to determine when a request has completed.When
stage
isSupergraphResponse
,hasNext
if present andtrue
indicates that there will be subsequentSupergraphResponse
calls to the co-processor for each multi-part (@defer
/subscriptions) response.See the coprocessor documentation for more details.
By @BrynCooke in #4017
Expose the ability to set topology spread constraints on the helm chart (3891)
Give developers the ability to set topology spread constraints that can be used to guarantee that federation pods are spread out evenly across AZs.
By bjoern in #3892
🐛 Fixes
Ignore JWKS keys which aren't supported by the router (Issue #3853)
If you have a JWKS which contains a key which has an algorithm (alg) which the router doesn't recognise, then the entire JWKS is disregarded. This is unsatisfactory, since there are likely to be many other keys in the JWKS which the router could use.
We have changed the JWKS processing logic so that we remove entries with an unrecognised algorithm from the list of available keys. We print a warning with the name of the algorithm for each removed entry.
By @garypen in #3922
Fix panic when streaming responses to co-processor (Issue #4013)
Streamed responses will no longer cause a panic in the co-processor plugin. This affected defer and stream queries.
By @BrynCooke in #4014
Only reject defer/subscriptions if actually part of a batch (Issue #3956)
Fix the checking logic so that deferred queries or subscriptions will only be rejected when experimental batching is enabled and the operations are part of a batch.
Without this fix, all subscriptions or deferred queries would be rejected when experimental batching support was enabled.
By @garypen in #3959
Fix requires selection in arrays (Issue #3972)
When a field has a
@requires
annotation that selects an array, and some fields are missing in that array or some of the elements are null, the router would short circuit the selection and remove the entire array. This relaxes the condition to allow nulls in the selected arrayBy @Geal in #3975
Fix router hang when opening the explorer, prometheus or health check page (Issue #3941)
The Router did not gracefully shutdown when an idle connections are made by a client, and would instead hang. In particular, web browsers make such connection in anticipation of future traffic.
This is now fixed, and the Router will now gracefully shut down in a timely fashion.
By @Geal in #3969
Fix hang and high CPU usage when compressing small responses (PR #3961)
When returning small responses (less than 10 bytes) and compressing them using gzip, the router could go into an infinite loop
By @Geal in #3961
📃 Configuration
Add
enabled
field for telemetry exporters (PR #3952)Telemetry configuration now supports
enabled
on all exporters. This allows exporters to be disabled without removing them from the configuration and in addition allows for a more streamlined default configuration.Existing configurations will be migrated to the new format automatically on startup. However, you should update your configuration to use the new format as soon as possible.
By @BrynCooke in #3952
🛠 Maintenance
Create a replacement self-signed server certificate: 10 years lifespan (Issue #3998)
This certificate is only used for testing, so 10 years lifespan is acceptable.
By @garypen in #4009
📚 Documentation
Updated documentation for deploying router (PR #3943)
Updated documentation for containerized router deployments, with guides and examples for deploying on Kubernetes and running on Docker.
By @shorgi in #3943
Document guidance for request and response buffering (Issue #3838)
Provides specific guidance on request and response buffering within the router.
By @garypen in #3970