Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

self-signed certificate used in tests has expired #3998

Closed
garypen opened this issue Oct 9, 2023 · 0 comments · Fixed by #4009
Closed

self-signed certificate used in tests has expired #3998

garypen opened this issue Oct 9, 2023 · 0 comments · Fixed by #4009
Assignees
@garypen

Comments

@garypen
Copy link
Contributor

garypen commented Oct 9, 2023 •
edited
Loading

We have a self-signed certificate checked into our tests which has expired:

% openssl x509 -in apollo-router/src/services/testdata/server_self_signed.crt -text
Certificate:
    Data:
        Version: 3 (0x2)
        Serial Number:
            0c:99:f8:36:8f:17:66:8f:b5:c5:41:04:32:aa:40:a9:18:b5:c6:65
        Signature Algorithm: sha256WithRSAEncryption
        Issuer: C = FR, O = Apollo GraphQL
        Validity
            Not Before: Sep  8 15:23:53 2023 GMT
            Not After : Oct  8 15:23:53 2023 GMT
<snip>

We should either:

  • generate a certificate dynamically for use in the test OR
  • replace this with a much longer lived cert

Important: remember to revert #3999 as part of the fix for this issue.
@garypen garypen changed the title disable self-signed certificate used in tests has expired Oct 9, 2023
@garypen garypen self-assigned this Oct 9, 2023
garypen added a commit that referenced this issue Oct 9, 2023
@garypen
disable self-signed certificate tls test
96a7cc1 
until we figure out a fix for: #3998
@garypen garypen mentioned this issue Oct 9, 2023
Merged
garypen added a commit that referenced this issue Oct 9, 2023
@garypen
disable self-signed certificate tls test (#3999)
56d9b72 
until we figure out a fix for:
#3998
@garypen garypen removed their assignment Oct 9, 2023
garypen added a commit that referenced this issue Oct 10, 2023
@garypen
create a replacement self-signed server certificate with 10 years lif…
31e8128 
…espan

This certificate is only used for testing, so 10 years lifespan is
acceptable.

fixes: #3998
@garypen garypen mentioned this issue Oct 10, 2023
Merged
6 tasks
garypen added a commit that referenced this issue Oct 10, 2023
@garypen
create a replacement self-signed server certificate with 10 years lif… (
e1af2ec 
#4009)

…espan

This certificate is only used for testing, so 10 years lifespan is
acceptable.

fixes: #3998

<!-- start metadata -->
---

**Checklist**

Complete the checklist (and note appropriate exceptions) before the PR
is marked ready-for-review.

- [x] Changes are compatible[^1]
- [x] Documentation[^2] completed
- [x] Performance impact assessed and acceptable
- Tests added and passing[^3]
    - [x] Unit Tests
    - [ ] Integration Tests
    - [ ] Manual Tests

**Exceptions**

*Note any exceptions here*

**Notes**

[^1]: It may be appropriate to bring upcoming changes to the attention
of other (impacted) groups. Please endeavour to do this before seeking
PR approval. The mechanism for doing this will vary considerably, so use
your judgement as to how and when to do this.
[^2]: Configuration is an important part of many changes. Where
applicable please try to document configuration examples.
[^3]: Tick whichever testing boxes are applicable. If you are adding
Manual Tests, please document the manual testing (extensively) in the
Exceptions.
This was referenced Oct 17, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garypen garypen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

create a replacement self-signed server certificate with 10 years lif… apollographql/router
1 participant
@garypen