release: v1.28.1 #3696
Merged
release: v1.28.1 #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove inaccurate comment about jsonpath_rust needing to clone
I got some changes merged upstream so now no cloning!
<!-- start metadata -->
**Checklist**
Complete the checklist (and note appropriate exceptions) before a final
PR is raised.
- [ ] Changes are compatible[^1]
- [ ] Documentation[^2] completed
- [ ] Performance impact assessed and acceptable
- Tests added and passing[^3]
- [ ] Unit Tests
- [ ] Integration Tests
- [ ] Manual Tests
**Exceptions**
*Note any exceptions here*
**Notes**
[^1]. It may be appropriate to bring upcoming changes to the attention
of other (impacted) groups. Please endeavour to do this before seeking
PR approval. The mechanism for doing this will vary considerably, so use
your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where
applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding
Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or
ask for it to be labeled) as `manual test`
Co-authored-by: bryn <[email protected]>
*Description here* Fixes #3658 <!-- start metadata --> **Checklist** Complete the checklist (and note appropriate exceptions) before a final PR is raised. - [x] Changes are compatible[^1] - [ ] Documentation[^2] completed - [ ] Performance impact assessed and acceptable - Tests added and passing[^3] - [ ] Unit Tests - [ ] Integration Tests - [ ] Manual Tests **Exceptions** *Note any exceptions here* **Notes** Right now, I've set it to take the max possible value for `PlanNode::Condition`. An alternative would be to return the min-max possible values for the number of subgraph fetches instead. Let me know what you folks prefer. [^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests: - please document the manual testing (extensively) in the Exceptions. - please raise a separate issue to automate the test and label it (or ask for it to be labeled) as `manual test`
…not exist (#3661) The Router will no longer log an error in when fetching from Redis and the record doesn't exist. This affected APQ, QueryPlanning and experimental entity caching. Fixes #2876 <!-- start metadata --> **Checklist** Complete the checklist (and note appropriate exceptions) before a final PR is raised. - [ ] Changes are compatible[^1] - [ ] Documentation[^2] completed - [ ] Performance impact assessed and acceptable - Tests added and passing[^3] - [ ] Unit Tests - [ ] Integration Tests - [ ] Manual Tests **Exceptions** *Note any exceptions here* **Notes** [^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests: - please document the manual testing (extensively) in the Exceptions. - please raise a separate issue to automate the test and label it (or ask for it to be labeled) as `manual test` --------- Co-authored-by: bryn <[email protected]>
Follow-up to the v1.28.0 being officially released, bringing version bumps and changelog updates into the `dev` branch.
Currently `extraContainers` are declared after the router container. Moving the `extraContainers` ahead of the router container will make it simpler to co-ordinate container startup sequencing and take full advantage of kubernetes lifecycle hooks. fixes: #3632 <!-- start metadata --> **Checklist** Complete the checklist (and note appropriate exceptions) before a final PR is raised. - [x] Changes are compatible[^1] - [x] Documentation[^2] completed - [x] Performance impact assessed and acceptable - Tests added and passing[^3] - [ ] Unit Tests - [ ] Integration Tests - [ ] Manual Tests **Exceptions** *Note any exceptions here* **Notes** [^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. [^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples. [^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests: - please document the manual testing (extensively) in the Exceptions. - please raise a separate issue to automate the test and label it (or ask for it to be labeled) as `manual test` --------- Co-authored-by: Jesse Rosenberger <[email protected]> Co-authored-by: o0Ignition0o <[email protected]> Co-authored-by: Bryn Cooke <[email protected]> Co-authored-by: bryn <[email protected]> Co-authored-by: Geoffroy Couprie <[email protected]> Co-authored-by: Lenny Burdette <[email protected]> Co-authored-by: Maria Elisabeth Schreiber <[email protected]> Co-authored-by: Lucas Leadbetter <[email protected]> Co-authored-by: Simon Sapin <[email protected]> Co-authored-by: Chandrika Srinivasan <[email protected]> Co-authored-by: Nicolas Moutschen <[email protected]>
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [apollo-compiler](https://togithub.com/apollographql/apollo-rs) | dependencies | patch | `0.11.0` -> `0.11.1` | | [apollo-parser](https://togithub.com/apollographql/apollo-rs) | dependencies | patch | `0.6.0` -> `0.6.1` | | [apollo-parser](https://togithub.com/apollographql/apollo-rs) | build-dependencies | patch | `0.6.0` -> `0.6.1` | --- ### Release Notes <details> <summary>apollographql/apollo-rs (apollo-compiler)</summary> ### [`v0.11.1`](https://togithub.com/apollographql/apollo-rs/releases/tag/apollo-compiler%400.11.1) [Compare Source](https://togithub.com/apollographql/apollo-rs/compare/[email protected]@0.11.1) #### Features - disable colours in diagnostics output if the terminal is not interactive, by [EverlastingBugstopper] in [pull/628], [issue/499] [EverlastingBugstopper]: https://togithub.com/EverlastingBugstopper [pull/628]: https://togithub.com/apollographql/apollo-rs/pull/628 [issue/499]: https://togithub.com/apollographql/apollo-rs/issues/499 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/apollographql/router). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi41Ni4wIiwidXBkYXRlZEluVmVyIjoiMzYuNjguMCIsInRhcmdldEJyYW5jaCI6ImRldiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Renée Kooi <[email protected]>
The issue is described in detail here: #3686 This PR uses `Weak` references to `Configuration` inside `Notify`'s broadcast channel. This was causing a memory leak on router reload. If the `upgrade` in the `subscription_task` is not successful, we cannot update, so it is simply skipped this time, waiting for the next valid configuration broadcast. I'm not sure what the best way to test this is within the router test suite. Happy to hear suggestions. I've validated it remediates the memory leak issue on our end. Co-authored-by: Jesse Rosenberger <[email protected]>
](https://renovatebot.com){kind=link}
|
CI performance tests
|
BrynCooke
approved these changes
Aug 28, 2023
o0Ignition0o
approved these changes
Aug 28, 2023
abernix
added a commit
that referenced
this pull request
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents the merge to
mainof the v1.28.1 release.This PR is primarily a merge commit, so reviewing every individual commit shown below is not necessary since those have been reviewed in their own PR.
However! Some things to review on this PR:
main)If those things look good, this PR is good to merge.