Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to otel 0.20.0 #3649

Merged
merged 34 commits into from
Sep 27, 2023
Merged
Show file tree
Hide file tree
Changes from 24 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
f6a67b6
Update to opentelemetry 0.20
Sep 15, 2023
b85c699
Add comment
Sep 18, 2023
e4ab716
Make creation of registered metrics atomic otherwise there would be a…
Sep 19, 2023
8ede811
Add dev docs
Sep 19, 2023
e9b6b8f
Improve dev docs a bit more
Sep 20, 2023
0cb3f3d
Improve dev docs a bit more
Sep 20, 2023
4b6181e
Update dev-docs/metrics.md
BrynCooke Sep 20, 2023
630c634
Add test for multiple calls to metrics
Sep 20, 2023
26fc686
Doc fixes
Sep 20, 2023
62b2d69
No need to use a boxed meter
Sep 20, 2023
356673c
Preallocate vecs to the correct size.
Sep 20, 2023
9f9a1a6
Fix metric that accidentally got renamed.
Sep 20, 2023
2117044
Add another lock for a prometheus test
Sep 20, 2023
0b8561f
Fix service.name detection.
Sep 21, 2023
094c2b9
Lint
Sep 21, 2023
95dc614
Changelog
Sep 21, 2023
9dd2ca8
Merge branch 'dev' into bryn/otel-update
Sep 21, 2023
588d67f
Changelog
Sep 21, 2023
1c5869b
Docs and changelog
Sep 21, 2023
f0c9354
Add gauge test and add some docs.
Sep 21, 2023
aa2fab7
Fix accidentally renamed metric
Sep 21, 2023
67957bd
Add tests for metric names
Sep 21, 2023
069742c
Merge dev
Sep 22, 2023
040dfb7
improve metrics macros (#3880)
bnjjj Sep 22, 2023
48ecaa3
Make metrics assertions type specific
Sep 25, 2023
a3fa457
Fix gauge test
Sep 25, 2023
0a65766
Make prom tests ignore reload.
Sep 25, 2023
286f3e7
Make linux use xlarge for builds in circle
Sep 26, 2023
b900187
Merge dev
Sep 26, 2023
8a65c2e
Update changelog
Sep 26, 2023
fba92d2
Fix alpha ordering in cargo toml
Sep 26, 2023
40acb7b
Add constant for unknown_service
Sep 26, 2023
5f69d6c
Merge dev
Sep 26, 2023
6516f2c
Update cargo lock
Sep 27, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions .changesets/maint_bryn_otel_update.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
### Update to OpenTelemetry 0.20.0 ([PR #3649](https://github.com/apollographql/router/pull/3649))

The router now uses OpenTelemetry 0.20.0. This includes a number of fixes and improvements from upstream.

In particular metrics have some significant changes:
* Prometheus metrics are now aligned with the [OpenTelemetry spec](https://opentelemetry.io/docs/specs/otel/compatibility/prometheus_and_openmetrics/), and will not report `service_name` on each individual metric. Resource attributes are now moved to a single `target_info` metric.

Users should check that their dashboards and alerts are properly configured when upgrading.

* The default service name for metrics is now `unknown_service` as per the [OpenTelemetry spec](https://opentelemetry.io/docs/concepts/sdk-configuration/general-sdk-configuration/#otel_service_name).

Users should ensure to configure service name via router.yaml, or via the `OTEL_SERVICE_NAME` environment variable.

We will be following bring tracing into alignment in future.
BrynCooke marked this conversation as resolved.
Show resolved Hide resolved

* The order of priority for setting service name has been brought into line with the rest of the router configuration. The order of priority is now:
1. `OTEL_RESOURCE_ATTRIBUTES` environment variable
2. `OTEL_SERVICE_NAME` environment variable
3. `resource_attributes` in router.yaml
4. `service_name` in router.yaml

By [@BrynCooke](https://github.com/BrynCooke) in https://github.com/apollographql/router/pull/3649
Loading