-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to otel 0.20.0 #3649
Update to otel 0.20.0 #3649
Changes from 1 commit
f6a67b6
b85c699
e4ab716
8ede811
e9b6b8f
0cb3f3d
4b6181e
630c634
26fc686
62b2d69
356673c
9f9a1a6
2117044
0b8561f
094c2b9
95dc614
9dd2ca8
588d67f
1c5869b
f0c9354
aa2fab7
67957bd
069742c
040dfb7
48ecaa3
a3fa457
0a65766
286f3e7
b900187
8a65c2e
fba92d2
40acb7b
5f69d6c
6516f2c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,16 +2,16 @@ | |
source: apollo-router/src/plugins/telemetry/mod.rs | ||
expression: prometheus_metrics | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't really understand this change, but won't this impact existing consumers of There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, I'm now confused also. Checking. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The metric was always called: In terms of why the snapshot has changed, it's because we no longer specify lots of extra attributes just for this prometheus test. The test is focused just on did prometheus serve up a result and did it look OK. Extra attributes are still tested in the new tests that use the testing macros, such as: |
||
--- | ||
apollo_router_http_requests_duration_bucket{status="200",otel_scope_name="apollo/router",le="+Inf"} 1 | ||
apollo_router_http_requests_duration_bucket{status="200",otel_scope_name="apollo/router",le="0.001"} 1 | ||
apollo_router_http_requests_duration_bucket{status="200",otel_scope_name="apollo/router",le="0.005"} 1 | ||
apollo_router_http_requests_duration_bucket{status="200",otel_scope_name="apollo/router",le="0.015"} 1 | ||
apollo_router_http_requests_duration_bucket{status="200",otel_scope_name="apollo/router",le="0.05"} 1 | ||
apollo_router_http_requests_duration_bucket{status="200",otel_scope_name="apollo/router",le="0.1"} 1 | ||
apollo_router_http_requests_duration_bucket{status="200",otel_scope_name="apollo/router",le="0.2"} 1 | ||
apollo_router_http_requests_duration_bucket{status="200",otel_scope_name="apollo/router",le="0.3"} 1 | ||
apollo_router_http_requests_duration_bucket{status="200",otel_scope_name="apollo/router",le="0.4"} 1 | ||
apollo_router_http_requests_duration_bucket{status="200",otel_scope_name="apollo/router",le="0.5"} 1 | ||
apollo_router_http_requests_duration_bucket{status="200",otel_scope_name="apollo/router",le="1"} 1 | ||
apollo_router_http_requests_duration_bucket{status="200",otel_scope_name="apollo/router",le="10"} 1 | ||
apollo_router_http_requests_duration_bucket{status="200",otel_scope_name="apollo/router",le="5"} 1 | ||
apollo_router_http_request_duration_seconds_bucket{status="200",otel_scope_name="apollo/router",le="+Inf"} 1 | ||
apollo_router_http_request_duration_seconds_bucket{status="200",otel_scope_name="apollo/router",le="0.001"} 1 | ||
apollo_router_http_request_duration_seconds_bucket{status="200",otel_scope_name="apollo/router",le="0.005"} 1 | ||
apollo_router_http_request_duration_seconds_bucket{status="200",otel_scope_name="apollo/router",le="0.015"} 1 | ||
apollo_router_http_request_duration_seconds_bucket{status="200",otel_scope_name="apollo/router",le="0.05"} 1 | ||
apollo_router_http_request_duration_seconds_bucket{status="200",otel_scope_name="apollo/router",le="0.1"} 1 | ||
apollo_router_http_request_duration_seconds_bucket{status="200",otel_scope_name="apollo/router",le="0.2"} 1 | ||
apollo_router_http_request_duration_seconds_bucket{status="200",otel_scope_name="apollo/router",le="0.3"} 1 | ||
apollo_router_http_request_duration_seconds_bucket{status="200",otel_scope_name="apollo/router",le="0.4"} 1 | ||
apollo_router_http_request_duration_seconds_bucket{status="200",otel_scope_name="apollo/router",le="0.5"} 1 | ||
apollo_router_http_request_duration_seconds_bucket{status="200",otel_scope_name="apollo/router",le="1"} 1 | ||
apollo_router_http_request_duration_seconds_bucket{status="200",otel_scope_name="apollo/router",le="10"} 1 | ||
apollo_router_http_request_duration_seconds_bucket{status="200",otel_scope_name="apollo/router",le="5"} 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is that a rename? (appending
_seconds
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a rename. The original code is referencing
metrics.http_requests_duration
which is declared as:apollo_router_http_request_duration_seconds
.