FTV1 support #1514
Merged
FTV1 support #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Fix clippy errors
Signed-off-by: Benjamin Coenen <[email protected]>
…j/ftv1_spaceport_send
Signed-off-by: Benjamin Coenen <[email protected]>
…j/ftv1_spaceport_send
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
abernix
previously requested changes
Aug 22, 2022
…e not output to regilar trace providers.
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
Signed-off-by: Benjamin Coenen <[email protected]>
send_headers config now uses HeaderName Simplify and correct population logic for variables and headers.
added 12 commits
September 5, 2022 17:50
Remove shared exporter for telemetry and metrics.
* field_execution_weight * duration_ns * sent_time_offset * path Pull out some strings into constants. Not tacked is lifecycle issues which need to be revisited separately.
This was referenced Sep 8, 2022
bnjjj
requested changes
Sep 8, 2022
apollo-router/src/plugins/telemetry/tracing/apollo_telemetry.rs
Outdated
Show resolved
Hide resolved
apollo-router/src/plugins/telemetry/tracing/apollo_telemetry.rs
Outdated
Show resolved
Hide resolved
apollo-router/src/plugins/telemetry/tracing/apollo_telemetry.rs
Outdated
Show resolved
Hide resolved
bnjjj
approved these changes
Sep 8, 2022
|
Very exciting to see this merged! Great work! |
This was referenced Sep 12, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds FTV1 support.
A new open telemetry exporter has been added that will convert regular traces to Apollo traces.
A buffer of spans is collected on the server side which will retain spans until the root request span is completed.
Once a request is completed the trace will be reconstructed and sent to Apollo.
Span attributes that are only relevant to Apollo tracing are prefixed with
apollo_private.and are filtered out of other APM data.@glasser Has given some guidance on how we should improve tracing, but this'll be left to followup tickets as this PR is large and has been ongoing for a significant period.
As an aside, this PR demonstrates that spans can be used for Apollo tracing, and that we could move to a native Otel based solution in future.