Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only interesting FTV1 traces should be sent #1729

Open
BrynCooke opened this issue Sep 8, 2022 · 0 comments
Open

Only interesting FTV1 traces should be sent #1729

BrynCooke opened this issue Sep 8, 2022 · 0 comments
Assignees
@BrynCooke
Labels
enhancement An enhancement to an existing feature

Comments

@BrynCooke
Copy link
Contributor

FTV1 traces are heavy, and we should therefore only send them if they look interesting.
They are already filtered on the server side, but it is a wast of bandwidth to send them in the first place if they are not interesting.

More info here: #1514 (comment)
@BrynCooke BrynCooke mentioned this issue Sep 8, 2022
Merged
2 tasks
BrynCooke added a commit that referenced this issue Sep 8, 2022
@BrynCooke @bnjjj
@o0Ignition0o @abernix @garypen
FTV1 support (#1514)
514bb86 
Adds FTV1 support.

A new open telemetry exporter has been added that will convert regular
traces to Apollo traces.

A buffer of spans is collected on the server side which will retain
spans until the root request span is completed.
Once a request is completed the trace will be reconstructed and sent to
Apollo.

Span attributes that are only relevant to Apollo tracing are prefixed
with `apollo_private.` and are filtered out of other APM data.

@glasser Has given some guidance on how we should improve tracing, but
this'll be left to followup tickets as this PR is large and has been
ongoing for a significant period.

- [ ] [Don't send ftv1 traces to free tier
users](#1728).
- [ ] [Only send ftv1 traces that are
interesting](#1729).

As an aside, this PR demonstrates that spans can be used for Apollo
tracing, and that we could move to a native Otel based solution in
future.

Signed-off-by: Benjamin Coenen <[email protected]>
Co-authored-by: bryn <[email protected]>
Co-authored-by: Benjamin Coenen <[email protected]>
Co-authored-by: o0Ignition0o <[email protected]>
Co-authored-by: Coenen Benjamin <[email protected]>
Co-authored-by: Jesse Rosenberger <[email protected]>
Co-authored-by: Gary Pennington <[email protected]>
@abernix abernix added this to the post-v1.0 milestone Sep 10, 2022
@BrynCooke BrynCooke mentioned this issue Sep 12, 2022
Closed
@abernix abernix added enhancement An enhancement to an existing feature and removed triage raised by user labels Sep 12, 2022
@abernix abernix removed this from the v1.x.x milestone Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrynCooke BrynCooke

Labels
enhancement An enhancement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BrynCooke @abernix