Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No variables present in the Apollo Studio even with send_variable_values set #2186

Closed
radekmie opened this issue Dec 1, 2022 · 0 comments · Fixed by #2190
Closed

No variables present in the Apollo Studio even with send_variable_values set #2186

radekmie opened this issue Dec 1, 2022 · 0 comments · Fixed by #2190
Assignees

Comments

@radekmie
Copy link

radekmie commented Dec 1, 2022

Describe the bug
We've deployed Router 1.3 a couple of days ago and wanted to see how the telemetry works in there (we were at pre-1.0 before). To do that, we added the following configuration:

telemetry:
    apollo:
        field_level_instrumentation_sampler: 1.0 # Just for tests.
        send_headers: all
        send_variable_values: all
    tracing:
        trace_config:
            sampler: 1.0 # Just for tests.

The headers are there (I mean, their values - their names were already there), field level instrumentation also works. However, none of the values is present. We've also tried to list them explicitly:

telemetry:
    apollo:
        send_variable_values:
            only:
                - input

But it didn't change anything. Are we missing something or is it a bug?

To Reproduce
Steps to reproduce the behavior:

  1. Setup the Router with any configuration and add the telemetry config I posted above.
  2. Execute a couple of GraphQL requests against it.
  3. Check the Apollo Studio for traces.

Expected behavior
Traces are there, their headers are present, and so are values.

Output
Traces are there, their headers are present, but values are not.

@bnjjj bnjjj self-assigned this Dec 2, 2022
@BrynCooke BrynCooke self-assigned this Dec 2, 2022
@bnjjj bnjjj removed their assignment Dec 2, 2022
BrynCooke pushed a commit that referenced this issue Dec 2, 2022
Fix missing variables that were:
1. being serialized incorrectly when being placed on a span.
2. being searched for in the request span rather than the supergraph

Make tests better by using insta redaction.
Fixes #2186
@BrynCooke BrynCooke linked a pull request Dec 2, 2022 that will close this issue
BrynCooke added a commit that referenced this issue Dec 2, 2022
You can now view traces in Apollo Studio as normal.
Also improved testing and fixed missing variables in Apollo tracing.
Fixes #1600 #2186
 

<!--
First, 🌠 thank you 🌠 for considering a contribution to Apollo!

Some of this information is also included in the /CONTRIBUTING.md file
at the
root of this repository.  We suggest you read it!

  https://github.com/apollographql/router/blob/HEAD/CONTRIBUTING.md

Here are some important details to keep in mind:

* ⏰ Your time is important
To save your precious time, if the contribution you are making will
take more than an hour, please make sure it has been discussed in an
        issue first. This is especially true for feature requests!

* 💡 Features
Feature requests can be created and discussed within a GitHub Issue.
Be sure to search for existing feature requests (and related issues!)
prior to opening a new request. If an existing issue covers the need,
please upvote that issue by using the 👍 emote, rather than opening a
        new issue.

* 🕷 Bug fixes
These can be created and discussed in this repository. When fixing a
bug,
please _try_ to add a test which verifies the fix. If you cannot, you
should
still submit the PR but we may still ask you (and help you!) to create a
test.

* 📖 Contribution guidelines
Follow https://github.com/apollographql/router/blob/HEAD/CONTRIBUTING.md
when submitting a pull request. Make sure existing tests still pass, and
add
        tests for all new behavior.

* ✏️ Explain your pull request
Describe the big picture of your changes here to communicate to what
        your pull request is meant to accomplish. Provide 🔗 links 🔗 to
associated issues! Documentation in the docs/ directory should be
updated
        as necessary.  Finally, a /CHANGELOG.md entry should be added.

We hope you will find this to be a positive experience! Contribution can
be
intimidating and we hope to alleviate that pain as much as possible.
Without
following these guidelines, you may be missing context that can help you
succeed
with your contribution, which is why we encourage discussion first.
Ultimately,
there is no guarantee that we will be able to merge your pull-request,
but by
following these guidelines we can try to avoid disappointment.

-->

Co-authored-by: bryn <[email protected]>
@BrynCooke BrynCooke modified the milestones: v1-NEXT, v1.5.0 Dec 2, 2022
@garypen garypen added this to the v1.5.0 milestone Dec 5, 2022
@BrynCooke BrynCooke modified the milestone: v1.5.0 Dec 5, 2022
@abernix abernix removed the triage label Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants