-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Defer: ftv1 support #1600
Comments
Ideally we can come up with a solution that is backwards-compatible with the current protobuf protocol, in the sense that for a "good enough" experience we can think of deferred fetches as simply additional nodes in the trace. I'd like to vet that assumption as I've heard mention of things like modifying the protobuf to include finer-grained defer semantics, and it would be great to avoid that if we can in the short-term. |
As a response to the above thought, a hot take from @glasser:
|
You can now view traces in Apollo Studio as normal. Fixes #1600
You can now view traces in Apollo Studio as normal. Fixes #1600
You can now view traces in Apollo Studio as normal. Fixes #1600
You can now view traces in Apollo Studio as normal. Also improved testing and fixed missing variables in Apollo tracing. Fixes #1600 #2186 <!-- First, 🌠 thank you 🌠 for considering a contribution to Apollo! Some of this information is also included in the /CONTRIBUTING.md file at the root of this repository. We suggest you read it! https://github.com/apollographql/router/blob/HEAD/CONTRIBUTING.md Here are some important details to keep in mind: * ⏰ Your time is important To save your precious time, if the contribution you are making will take more than an hour, please make sure it has been discussed in an issue first. This is especially true for feature requests! * 💡 Features Feature requests can be created and discussed within a GitHub Issue. Be sure to search for existing feature requests (and related issues!) prior to opening a new request. If an existing issue covers the need, please upvote that issue by using the 👍 emote, rather than opening a new issue. * 🕷 Bug fixes These can be created and discussed in this repository. When fixing a bug, please _try_ to add a test which verifies the fix. If you cannot, you should still submit the PR but we may still ask you (and help you!) to create a test. * 📖 Contribution guidelines Follow https://github.com/apollographql/router/blob/HEAD/CONTRIBUTING.md when submitting a pull request. Make sure existing tests still pass, and add tests for all new behavior. * ✏️ Explain your pull request Describe the big picture of your changes here to communicate to what your pull request is meant to accomplish. Provide 🔗 links 🔗 to associated issues! Documentation in the docs/ directory should be updated as necessary. Finally, a /CHANGELOG.md entry should be added. We hope you will find this to be a positive experience! Contribution can be intimidating and we hope to alleviate that pain as much as possible. Without following these guidelines, you may be missing context that can help you succeed with your contribution, which is why we encourage discussion first. Ultimately, there is no guarantee that we will be able to merge your pull-request, but by following these guidelines we can try to avoid disappointment. --> Co-authored-by: bryn <[email protected]>
Followup to #1599 where i disabled sending traces for defered queries, we want to have a look at what needs to be done so we can support it
The text was updated successfully, but these errors were encountered: