Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Avoid React 16.13.0 update during render warning #3930

Merged
merged 1 commit into from
Apr 14, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Changelog.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Change log

## 3.1.5 (2020-04-14)

- Another pass at preventing new data re-render attempts during an existing render (the solution published with React Apollo 3.1.4 wasn't as all encompassing as it needs to be). This helps avoid React 16.13.0's "Cannot update a component from inside the function body of a different component" warning (https://github.com/facebook/react/pull/17099). <br/>
[@hwillson](https://github.com/hwillson) in [#3930](https://github.com/apollographql/react-apollo/pull/3930)

## 3.1.4 (2020-04-03)

- Prevent new data re-render attempts during an existing render. This helps avoid React 16.13.0's "Cannot update a component from inside the function body of a different component" warning (https://github.com/facebook/react/pull/17099). <br/>
Expand Down Expand Up @@ -1181,7 +1186,7 @@ import { getDataFromTree, renderToStringWithData } from 'react-apollo';
renderToStringWithData(component).then({ markup, initialState });

// new -- you must get it yourself
renderToStringWithData(component).then(markup => {
renderToStringWithData(component).then((markup) => {
const initialState = client.store.getState()[client.reduxRootKey];

// ...
Expand Down
Loading