This repository has been archived by the owner on Apr 13, 2023. It is now read-only.
Avoid React 16.13.0 update during render warning #3930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwillson
force-pushed
the
issue-3863-again
branch
from
2512e28 to
f0f2d2b
Compare
As of version 16.13.0, React logs a warning when a function component is updated during another component's render phase (facebook/react#17099). PR #3902 addresses some of this, but doesn't quite catch all scenarios where this can occur. These changes take things further, ensuring that React Apollo components can't force update during a render phase.
hwillson
force-pushed
the
issue-3863-again
branch
from
6c11d11 to
63f8a19
Compare
hwillson
added a commit
to apollographql/apollo-client
that referenced
this pull request
Apr 16, 2020
Prevent new data re-render attempts during an existing render to help avoid React 16.13.0's "Cannot update a component from inside the function body of a different component" warning (facebook/react#17099). These changes were originally implemented in apollographql/react-apollo#3930.
hwillson
added a commit
to apollographql/apollo-client
that referenced
this pull request
Apr 16, 2020
Prevent new data re-render attempts during an existing render to help avoid React 16.13.0's "Cannot update a component from inside the function body of a different component" warning (facebook/react#17099). These changes were originally implemented in apollographql/react-apollo#3930.
benjamn
pushed a commit
to apollographql/apollo-client
that referenced
this pull request
May 4, 2020
Prevent new data re-render attempts during an existing render to help avoid React 16.13.0's "Cannot update a component from inside the function body of a different component" warning (facebook/react#17099). These changes were originally implemented in apollographql/react-apollo#3930.
benjamn
pushed a commit
to apollographql/apollo-client
that referenced
this pull request
May 4, 2020
Prevent new data re-render attempts during an existing render to help avoid React 16.13.0's "Cannot update a component from inside the function body of a different component" warning (facebook/react#17099). These changes were originally implemented in apollographql/react-apollo#3930.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of version 16.13.0, React logs a warning when a function component is updated during another component's render phase (facebook/react#17099). PR #3902 addresses some of this, but doesn't quite catch all scenarios where this can occur. These changes take things further, ensuring that React Apollo components can't force update during a render phase.
Fixes #3863