Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

fix lodash typings #2430

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Conversation

williamboman
Copy link
Contributor

ref: #2332

@apollo-cla
Copy link

@williamboman: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@disintegrator
Copy link

I'm curious why pull lodash in to get flowRight. In my mind inlining the function into react-apollo is a safer and lighter option. Am I missing something?

@williamboman
Copy link
Contributor Author

I'm curious why pull lodash in to get flowRight. In my mind inlining the function into react-apollo is a safer and lighter option. Am I missing something?

For sure - will take a look at it

@williamboman
Copy link
Contributor Author

williamboman commented Sep 28, 2018

Actually, never mind. I'm gonna leave it as is. The comment in the code suggests it'll be removed next major version, and ensuring feature and typings parity with Lodash's flowRight function is gonna be difficult.

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @williamboman!

@hwillson hwillson merged commit efdc5a0 into apollographql:master Sep 28, 2018
@williamboman williamboman deleted the fix/lodash-typings branch September 28, 2018 13:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants