Skip to content
This repository has been archived by the owner on Apr 13, 2023. It is now read-only.

Import lodash/flowRight using ES import to allow for treeshaking #2332

Merged
merged 2 commits into from
Sep 21, 2018

Conversation

Pajn
Copy link
Contributor

@Pajn Pajn commented Aug 31, 2018

Fixes #2306

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.

Copy link
Member

@hwillson hwillson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @Pajn!

@hwillson hwillson merged commit b85b25c into apollographql:master Sep 21, 2018
@williamboman
Copy link
Contributor

williamboman commented Sep 26, 2018

Hey! This seems to break typings in projects that have both react-apollo and @types/lodash in the dependency tree?

ERROR in /Users/william.boman/dev/app/node_modules/react-apollo/browser.d.ts(17,36):
TS2497: Module '"/Users/william.boman/dev/app/node_modules/@types/lodash/flowRight"' resolves to a non-module entity and cannot be imported using this construct.

@danilobuerger
Copy link
Contributor

@hwillson @Pajn this should be reverted, breaks typings as pointed out by @williamboman

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use import for lodash/flowRight to allow for tree shaking
4 participants