Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to @apollo/utils packages for createSHA and isNodeLike #1765

Merged
merged 2 commits into from
Apr 23, 2022

Conversation

trevor-scheer
Copy link
Member

@trevor-scheer trevor-scheer commented Apr 22, 2022

These functions are common logic between the server and federation monorepos so it's been moved into the utils monorepo. Most importantly, this removes a deep import from 'apollo-server-core/dist/utils/createSHA' which is a dependency the server team is hoping to remove over time.

@netlify
Copy link

netlify bot commented Apr 22, 2022

Deploy Preview for apollo-federation-docs canceled.

Name Link
🔨 Latest commit 9f0ede6
🔍 Latest deploy log https://app.netlify.com/sites/apollo-federation-docs/deploys/626325696aac8b000954acea

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 22, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

@benweatherman benweatherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

package.json Outdated Show resolved Hide resolved
@trevor-scheer trevor-scheer merged commit 2df7246 into main Apr 23, 2022
@trevor-scheer trevor-scheer deleted the trevor/use-utils branch April 23, 2022 00:10
benweatherman added a commit that referenced this pull request Apr 25, 2022
# [2.0.2-alpha.0] - 2022-04-22

## 🚀 Features

- Improve fed1 schema support during composition [PR #1735](#1735)
- Add gateway version to schema extensions [PR #1751](#1751)

## 🐛 Fixes

- Improve merging of groups during `@require` handling in query planning [PR #1732](#1732)
- Move `__resolveReference` resolvers on to `extensions` [PR #1746](#1746)
- Honor directive imports when directive name is spec name [PR #1720](#1720)

## 🛠 Maintenance

- Improved renovate bot auto-updates for 0.x packages [PR #1736](#1736) and [PR #1730](#1730)
- Add missing `@apollo/federation-internals` dependency to gateway [PR #1721](#1721)
- Migrate to `@apollo/utils` packages for `createSHA` and `isNodeLike` [PR #1765](#1765)

## 📚 Documentation

- Roadmap updates! [PR #1717](#1717)
- Clarify separation of concerns in the intro docs [PR #1753](#1753)
- Update intro example for fed2 [PR #1741](#1741)
- Improve error doc generation, add hints generation, add scrolling style to too-large error tables [PR #1740](#1740)
- Update `supergraphSDL` to be a string when creating an `ApolloGateway` [PR #1744](#1744)
- Federation subgraph library compatibility updates [PR #1718](#1744)
@benweatherman benweatherman mentioned this pull request May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants