Add gateway version to schema extensions #1751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
- Added as an external file, possibly keeping inline with the existing code style for modifying schemas in the gateway - Added `genversion` so we could keep an updated version string in the gateway code without importing `package.json` directly (which has various problems, including importing the whole file and how to import the file in typescript from the root of the sub-package). ## TODO - [ ] Add typing info similar to the `__resolveReference` PR - [ ] Add tests Fixes #1749
benweatherman
force-pushed
the
weatherman/gateway-federation-extensions
branch
from
392a85b to
1be54a2
Compare
This standardizes using the `apollo.gateway` key structure for extensions and will make the typescript compiler happy
There are lots of places we use both `version` & `name` from the package file. There don't seem to be good solutions for pulling generic stuff out of the package file and I don't really want to create my own script, so I'm sticking with the existing pattern of reading the package file.
trevor-scheer
approved these changes
Apr 21, 2022
There was a problem hiding this comment.
LGTM. I do think having to add the typings file to the test tsconfig is curious and likely symptomatic of some bad config somewhere, but I'm not sure what and I'm perfectly comfortable moving forward with this as-is.
Worth noting this doesn't need a backport because fed1 gateway schema objects are identifiable whereas fed2 gateway schema objects have no metadata (that I'm aware of) to make them identifiable.
Merged
benweatherman
added a commit
that referenced
this pull request
Apr 25, 2022
# [2.0.2-alpha.0] - 2022-04-22 ## 🚀 Features - Improve fed1 schema support during composition [PR #1735](#1735) - Add gateway version to schema extensions [PR #1751](#1751) ## 🐛 Fixes - Improve merging of groups during `@require` handling in query planning [PR #1732](#1732) - Move `__resolveReference` resolvers on to `extensions` [PR #1746](#1746) - Honor directive imports when directive name is spec name [PR #1720](#1720) ## 🛠 Maintenance - Improved renovate bot auto-updates for 0.x packages [PR #1736](#1736) and [PR #1730](#1730) - Add missing `@apollo/federation-internals` dependency to gateway [PR #1721](#1721) - Migrate to `@apollo/utils` packages for `createSHA` and `isNodeLike` [PR #1765](#1765) ## 📚 Documentation - Roadmap updates! [PR #1717](#1717) - Clarify separation of concerns in the intro docs [PR #1753](#1753) - Update intro example for fed2 [PR #1741](#1741) - Improve error doc generation, add hints generation, add scrolling style to too-large error tables [PR #1740](#1740) - Update `supergraphSDL` to be a string when creating an `ApolloGateway` [PR #1744](#1744) - Federation subgraph library compatibility updates [PR #1718](#1744)
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds gateway version as a schema extension
TODO
__resolveReferencePRChange uses ofDecided against this because we would still need to importrequire("package.json")to the newly generated version filepackage.jsonto get the nameFixes #1749