-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement query planner tests #106
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some stuff
query-planner/tests/cucumber.rs
Outdated
}); | ||
} | ||
|
||
// TODO: how to ignore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One of the options is to conditionally compile the entire module:
#[cfg(feature = "with_qp_tests")]
mod cucumber
in mod.rs
(idk if mod.rs is a thing in a tests folder, if not we can put it on mod query_planner_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we saw yesterday, removing the [[test]]
section of the cargo.toml will still compile, but not run the cucumber tests, which seems like a decent middle-ground for now
Update: there is not |
95b2f30
to
4b18001
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just suggested a comment, but otherwise looks good!
Co-authored-by: Ran Magen <[email protected]>
Resolves #103
This PR takes the existing query planner test suite from the apollo-server repo (cradle) and sets up this project to run them whenever there is a runnable query planner.
The signature of the query planner that I've stubbed out here is from this discussion #101 (comment)
Right now, you can run this suite by running
cargo test
orcargo test -p apollo-query-planner --test cucumber
.Deliverables from #103: