Add mutation planning tests to cradle suite #4390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ported some tests from the existing mutation integration tests (from the gateway). I commented which those were and their corresponding tests from the gateway package (since I changed some names slightly) so we could go back later when we port _all_ tests to cucumber and remove them from this one mega-file :) I also added a simple, barebones, single-service test to make sure mutations build a simple fetch node to begin with
Enrico2
approved these changes
Jul 16, 2020
|
🎉 Does this close #4384, @JakeDawkins? |
Yep! (I'm apparently really bad at linking issues) |
abernix
pushed a commit
to apollographql/federation
that referenced
this pull request
Sep 4, 2020
…ver#4390) Ported some tests from the existing mutation integration tests (from the gateway). I commented which those were and their corresponding tests from the gateway package (since I changed some names slightly) so we could go back later when we port _all_ tests to cucumber and remove them from this one mega-file :) I also added a simple, barebones, single-service test to make sure mutations build a simple fetch node to begin with Apollo-Orig-Commit-AS: apollographql/apollo-server@9873ba4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I Ported some tests from the existing mutation integration tests (from the gateway). I commented which those were and their corresponding tests from the gateway package (since I changed some names slightly) so we could go back later when we port all tests to cucumber and remove them from this one mega-file (per the discussion here :)
I also added a simple, barebones, single-service test to make sure mutations build a simple fetch node to begin with
One this is merged, I'll update this PR with the new tests