Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): fix outdated "vendored" dependency #2089

Closed
wants to merge 1 commit into from

Conversation

squirly
Copy link

@squirly squirly commented Aug 24, 2020

The currently set version of the graphql-language-service bindings does not support graphql@15, causing npm to show peer-dependency errors when using graphql@15.

Show Error
npm WARN @apollographql/[email protected] requires a peer of graphql@^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @apollographql/[email protected] requires a peer of graphql@^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @apollographql/[email protected] requires a peer of graphql@^0.10.0 || ^0.11.0 || ^0.12.0 || ^0.13.0 || ^14.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN @apollographql/[email protected] requires a peer of graphql@^0.12.0 || ^0.13.0 || ^14.0.0 but none is installed. You must install peer dependencies yourself

The current version of the library supports the newer version of graphql, getting around this error.

Fixes #2039
Fixes #1822
Fixes #2005

@squirly
Copy link
Author

squirly commented Aug 24, 2020

Since graphql-language-service-types uses newer TypeScript language features (typescript >= 3.8), typescript must first be updated before this change can be made (see #2085).

@bdow
Copy link

bdow commented Sep 23, 2020

@squirly - I see in #2085 is attempting to do a major version bump of Typescript, though it is failing multiple circleci checks. Your note mentions it only needs to bump to 3.8, which seems to be a much simpler bump than doing a major version. Any chance we can do a minor bump to 3.8 for now in order to get this PR through and unblock users who want to upgrade to graphql@15?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants