Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Licensing issues with dependencies #5640

Closed
selfagency opened this issue Aug 22, 2021 · 10 comments
Closed

Licensing issues with dependencies #5640

selfagency opened this issue Aug 22, 2021 · 10 comments

Comments

@selfagency
Copy link

The following dependencies of Apollo Server/Apollo Client are throwing errors in my licensing compliance tools because they do not contain LICENSE files. Could you please add the appropriate licenses? Thank you.

  • @apollographql/graphql-language-service-interface
  • @apollographql/graphql-language-service-parser
  • @apollographql/graphql-language-service-types
  • @apollographql/graphql-language-service-utils
@glasser
Copy link
Member

glasser commented Aug 23, 2021

@selfagency Hi, good catch. These are forks of packages from https://github.com/graphql/graphiql that we haven't updated in a while, and the upstream didn't have licenses on them until graphql/graphiql#849

Will look into publishing versions with MIT license, but to check — are you sure that these are actually dependencies of Apollo Server? I don't actually think Apollo Server 3 depends on these, even transitively. Can you share a package-lock.json that shows that these were pulled in?

I think they are used by the apollo CLI, which we are in the process of fully deprecating.

@glasser
Copy link
Member

glasser commented Aug 23, 2021

(apollographql/apollo-tooling#1553 and apollographql/apollo-tooling#2089 are relevant to the CLI here. Going to figure out why @hwillson closed the latter recently. That said, the main fix here is killing off the apollo CLI. Are you using the apollo CLI, and for which commands?

@selfagency
Copy link
Author

selfagency commented Aug 23, 2021

Here's the first one

CleanShot 2021-08-23 at 18 03 07

And here are the other three

CleanShot 2021-08-23 at 18 03 33

So it's all coming in through apollo-language-server which is coming through apollo

CleanShot 2021-08-23 at 18 05 29

@glasser
Copy link
Member

glasser commented Aug 23, 2021

Yeah, apollo is the CLI that we are finally going to make the push to fully deprecate. It should not be a dependency of Apollo Server, so I'm going to close this issue; the other issues I linked are more relevant to apollo. That said, do you know what commands you use apollo for? I can advise on whether there are better replacements for them yet or if we're still in the process of making that transition possible.

@glasser glasser closed this as completed Aug 23, 2021
@selfagency
Copy link
Author

It appears it's vue-cli-apollo that is using the apollo cli.

@selfagency
Copy link
Author

Aaaaand finally, vue-cli-apollo is a dependency of @nuxtjs/apollo. So it seems the official Vue and Nuxt integrations for Apollo are dependent on a deprecated feature.

@selfagency
Copy link
Author

Anyhow, thanks for your help.

@glasser
Copy link
Member

glasser commented Aug 23, 2021

Thanks. Yeah, it looks like vue-cli-plugin-apollo depends on a lot of older stuff: the apollo CLI, Apollo Client 2 (AC3 was released over a year ago), Apollo Server 2, etc.

@selfagency
Copy link
Author

Looks like it hasn't been updated for over a year (15 mos). Ouch.

@selfagency
Copy link
Author

Appears other Nuxt users have noticed as well.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants