apollo-cache-control does not set HTTP headers

[blimmer]

I lost quite a bit of time to this and the tests finally showed me that enabling apollo-cache-control stops HTTP headers from being set.

apollo-server/packages/apollo-server-express/src/__tests__/ApolloServer.test.ts

Lines 761 to 773 in b712eef

	it('contains no cacheControl Headers and keeps extension with engine proxy', async () => {
	const { url: uri } = await createServer({
	typeDefs,
	resolvers,
	cacheControl: true,
	});
	const apolloFetch = createApolloFetch({ uri }).useAfter(
	(response, next) => {
	expect(response.response.headers.get('cache-control')).toBeNull();
	next();
	},
	);

This warning might help future folks.

Is this the expected behavior in all integrations? Or is this an oddity with apollo-server-express?

[apollo-cla]

@blimmer: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

[abernix]

This sounds like a bug, not a documentation problem. I appreciate you opening the issue, but if you have some time (and since you have a working reproduction, it seems!) do you mind looking into the source of the bug? Perhaps it's related to recent changes, such as #2715, but maybe trying some older versions would help confirm?

If you're not able to look into it, opening an issue would be great, but I certainly don't want us to solidify this into the documentation as the expected norm and not look back.

Thanks!

[blimmer]

No problem - I opened #2918