Prevent Cache-Control header from being set if response has errors #2715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes apollographql/apollo-cache-control#12
Adds a check for
errors
and fordata
before setting theCache-Control
header. This change is aligned with the logic in theapollo-server-plugin-response-cache
package:apollo-server/packages/apollo-server-plugin-response-cache/src/ApolloServerPluginResponseCache.ts
Lines 243 to 261 in 7db109e