Do not throw in Flows #4685
Merged
Do not throw in Flows #4685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-android-docs canceled.
|
BoD
force-pushed
the
do-not-throw-in-flows
branch
from
1cedd6c
to
2e4bbd6
Compare
libraries/apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/ApolloResponse.kt
Outdated
Show resolved
Hide resolved
...runtime/src/commonMain/kotlin/com/apollographql/apollo3/network/http/HttpNetworkTransport.kt
Outdated
Show resolved
Hide resolved
...ting-support/src/commonMain/kotlin/com/apollographql/apollo3/testing/TestNetworkTransport.kt
Outdated
Show resolved
Hide resolved
...ting-support/src/commonMain/kotlin/com/apollographql/apollo3/testing/TestNetworkTransport.kt
Outdated
Show resolved
Hide resolved
...ting-support/src/commonMain/kotlin/com/apollographql/apollo3/testing/TestNetworkTransport.kt
Show resolved
Hide resolved
libraries/apollo-runtime/src/commonMain/kotlin/com/apollographql/apollo3/ApolloCall.kt
Outdated
Show resolved
Hide resolved
BoD
force-pushed
the
do-not-throw-in-flows
branch
from
d4b55be
to
e5fb47e
Compare
BoD
commented
Feb 15, 2023
libraries/apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/ExecutionOptions.kt
Outdated
Show resolved
Hide resolved
BoD
force-pushed
the
do-not-throw-in-flows
branch
from
a78886f
to
3f535e9
Compare
libraries/apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/ApolloResponse.kt
Show resolved
Hide resolved
...ng/src/commonMain/kotlin/com/apollographql/apollo3/cache/normalized/ClientCacheExtensions.kt
Outdated
Show resolved
Hide resolved
...ng/src/commonMain/kotlin/com/apollographql/apollo3/cache/normalized/ClientCacheExtensions.kt
Outdated
Show resolved
Hide resolved
...ng/src/commonMain/kotlin/com/apollographql/apollo3/cache/normalized/ClientCacheExtensions.kt
Outdated
Show resolved
Hide resolved
...ng/src/commonMain/kotlin/com/apollographql/apollo3/cache/normalized/ClientCacheExtensions.kt
Outdated
Show resolved
Hide resolved
...ng/src/commonMain/kotlin/com/apollographql/apollo3/cache/normalized/ClientCacheExtensions.kt
Outdated
Show resolved
Hide resolved
...ng/src/commonMain/kotlin/com/apollographql/apollo3/cache/normalized/ClientCacheExtensions.kt
Show resolved
Hide resolved
...ng/src/commonMain/kotlin/com/apollographql/apollo3/cache/normalized/ClientCacheExtensions.kt
Outdated
Show resolved
Hide resolved
...pollo-http-cache/src/main/kotlin/com/apollographql/apollo3/cache/http/HttpCacheExtensions.kt
Show resolved
Hide resolved
.../src/commonMain/kotlin/com/apollographql/apollo3/cache/normalized/FetchPolicyInterceptors.kt
Outdated
Show resolved
Hide resolved
libraries/apollo-runtime/src/commonMain/kotlin/com/apollographql/apollo3/ApolloCall.kt
Outdated
Show resolved
Hide resolved
libraries/apollo-runtime/src/commonMain/kotlin/com/apollographql/apollo3/ApolloCall.kt
Outdated
Show resolved
Hide resolved
| .exception(AutoPersistedQueriesNotSupported()) | ||
| .build() | ||
| ) | ||
| return@flow |
...s/apollo-runtime/src/commonMain/kotlin/com/apollographql/apollo3/network/NetworkTransport.kt
Outdated
Show resolved
Hide resolved
BoD
force-pushed
the
do-not-throw-in-flows
branch
from
007a593
to
929aef6
Compare
libraries/apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/ApolloResponse.kt
Outdated
Show resolved
Hide resolved
libraries/apollo-api/src/commonMain/kotlin/com/apollographql/apollo3/api/ApolloResponse.kt
Show resolved
Hide resolved
...ng/src/commonMain/kotlin/com/apollographql/apollo3/cache/normalized/ClientCacheExtensions.kt
Outdated
Show resolved
Hide resolved
.../src/commonMain/kotlin/com/apollographql/apollo3/cache/normalized/FetchPolicyInterceptors.kt
Outdated
Show resolved
Hide resolved
.../src/commonMain/kotlin/com/apollographql/apollo3/cache/normalized/FetchPolicyInterceptors.kt
Show resolved
Hide resolved
libraries/apollo-runtime/src/commonMain/kotlin/com/apollographql/apollo3/ApolloCall.kt
Outdated
Show resolved
Hide resolved
libraries/apollo-runtime/src/commonMain/kotlin/com/apollographql/apollo3/ApolloCall.kt
Outdated
Show resolved
Hide resolved
| */ | ||
| fun <T> MutableExecutionOptions<T>.emitCacheMisses(emitCacheMisses: Boolean) = addExecutionContext( | ||
| EmitCacheMissesContext(emitCacheMisses) | ||
| ) |
There was a problem hiding this comment.
Keep it with DeprecationLevel.ERROR and a nice error message?
| fun <D : Query.Data> ApolloCall<D>.watch( | ||
| fetchThrows: Boolean = false, | ||
| refetchThrows: Boolean = false, | ||
| ): Flow<ApolloResponse<D>> { |
There was a problem hiding this comment.
Keep the overload with DeprecationLevel.ERROR?
| @@ -28,7 +27,6 @@ import com.apollographql.apollo3.interceptor.ApolloInterceptor | |||
| import com.apollographql.apollo3.interceptor.ApolloInterceptorChain | |||
| import com.apollographql.apollo3.mpp.currentTimeMillis | |||
| import kotlinx.coroutines.flow.Flow | |||
| import kotlinx.coroutines.flow.catch | |||
There was a problem hiding this comment.
There's a maybeWriteToCache in this file that certainly needs to check for response.exception before writing to the cache?
libraries/apollo-runtime/src/commonMain/kotlin/com/apollographql/apollo3/ApolloCall.kt
Show resolved
Hide resolved
…lloCompositeException
Also, keep some methods around instead of deleting them, with Error level deprecation, for binary compatibility.
...he/src/commonMain/kotlin/com/apollographql/apollo3/cache/normalized/ClientCacheExtensions.kt
Outdated
Show resolved
Hide resolved
…ported watch methods.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4003.
WebSocketNetworkTransportApolloCacheInterceptor,FetchPolicyInterceptor, andApolloCall,execute()accordinglyThrowingXyzInterceptors, and athrowApolloExceptionparameter ontoFloware added to get the old behavior backMissing:
ApolloCallback.onFailureand only keeponResponsesince reponse can have an exception