Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecation warnings #4610

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Add deprecation warnings #4610

merged 3 commits into from
Mar 14, 2023

Conversation

martinbonnin
Copy link
Contributor

Add messages during Gradle execution when any of those is used:

  • useVersion2Compat()
  • generateTestBuilders
  • useSchemaPackageNameForFragments
  • codegenModels.set("compat")

There is no way to disable the warning besides actually migrating, which I think is ok.

Copy link
Contributor

@BoD BoD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@martinbonnin martinbonnin marked this pull request as draft January 9, 2023 08:29
@martinbonnin
Copy link
Contributor Author

Heads up I'm moving this to draft to put any other future deprecations at the same time. This way we can properly signal a "deprecation" maintenance release in the changelog

@BoD BoD changed the base branch from release-3.x to release-3.7.5 March 14, 2023 17:50
@BoD BoD marked this pull request as ready for review March 14, 2023 17:54
@BoD BoD merged commit 7e426c9 into release-3.7.5 Mar 14, 2023
@BoD BoD deleted the deprecations branch March 14, 2023 17:54
@martinbonnin martinbonnin mentioned this pull request Mar 15, 2023
@martinbonnin martinbonnin mentioned this pull request Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants