Update Threading.md and change the dispatcher earlier in the chain #4319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
commented
Aug 4, 2022
.../src/commonMain/kotlin/com/apollographql/apollo3/cache/normalized/FetchPolicyInterceptors.kt
Outdated
Show resolved
Hide resolved
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
commented
Aug 4, 2022
|
Moving this to draft as it has a side effect of subscribing to the store asynchronously now and therefore is subject to race conditions. This is something we've seen in the past and would need to be revisited. |
martinbonnin
force-pushed
the
update-threading-md
branch
from
4bdf471
to
03c3860
Compare
✅ Deploy Preview for apollo-android-docs canceled.
|
martinbonnin
force-pushed
the
update-threading-md
branch
from
6bb5275
to
d732236
Compare
|
Marking this 2 years old PR as "ready for review". There are still CI flakes that I believe are not related to this PR and will address separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.