Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap more channel.offer calls #2058

Merged
merged 2 commits into from
Mar 11, 2020
Merged

Wrap more channel.offer calls #2058

merged 2 commits into from
Mar 11, 2020

Conversation

martinbonnin
Copy link
Contributor

@martinbonnin martinbonnin commented Mar 10, 2020 •
edited
Loading

Somehow I missed a few channel.offer in #2007? This should wrap all of them in runCatching

I also took this opportunity to remove toChannel extension functions in favor of toFlow for 1.4.0.

@martinbonnin
wrap more channel.offer calls
8539898 
Also remove `toChannel` extension functions in favor of `toFlow`
@martinbonnin martinbonnin merged commit 7e4dca7 into apollographql:master Mar 11, 2020
@ahetawal-p
Copy link

Seems the documentation on toDeferred needs to be fixed to remove references for toChannel
https://github.com/apollographql/apollo-android/blob/58faff8e262968eb3c81535533492e3cd587c08e/apollo-coroutines-support/src/main/kotlin/com/apollographql/apollo/coroutines/CoroutinesExtensions.kt#L78

@martinbonnin
Copy link
Contributor Author

@ahetawal-p Thanks for the heads up. Pull request there: #2092

@martinbonnin martinbonnin deleted the wrap-more-channel-offer branch March 23, 2020 09:55
tasomaniac pushed a commit that referenced this pull request Mar 23, 2020
@martinbonnin @tasomaniac
wrap more channel.offer calls (#2058)
20d21e8 
Also remove `toChannel` extension functions in favor of `toFlow`

(cherry picked from commit 7e4dca7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tasomaniac tasomaniac tasomaniac approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinbonnin @ahetawal-p @tasomaniac