Coroutines: make sure we do not crash when calling offer
#2007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinbonnin
commented
Feb 20, 2020
| override fun onResponse(response: Response<T>) { | ||
| if (!channel.isClosedForSend) { | ||
| runCatching { |
There was a problem hiding this comment.
@sav007 I feel the runCatching approach is safer since there could potentially be a race condition where the channel is closed just after the if before. Let me know if isClosedForSend was used to catch other cases.
There was a problem hiding this comment.
To avoid having to wrap the offer in a runCatching, you could create an extension on a Channel.
fun <E> SendChannel<E>.safeOffer(value: E) = runCatching {
offer(value)
}
There was a problem hiding this comment.
@msya, for 2 instances only, I'd rather not pollute the SendChannel namespace with an extension function.
sav007
approved these changes
Feb 22, 2020
msya
approved these changes
Feb 23, 2020
tasomaniac
pushed a commit
that referenced
this pull request
Mar 23, 2020
(cherry picked from commit 9e2a24f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2005
See Kotlin/kotlinx.coroutines#974
See #1585