Say Goodbye to Apollo CLI #2003
Merged
+12
−462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvincestari
commented
Oct 26, 2021
| @@ -1468,6 +1437,8 @@ | |||
| children = ( | |||
| 9BAEEBEB234663F200808306 /* ApolloSchemaDownloader.swift */, | |||
| 9BAEEBED2346644600808306 /* ApolloSchemaDownloadConfiguration.swift */, | |||
| 9BCA8C0826618226004FF2F6 /* UntypedGraphQLRequestBodyCreator.swift */, | |||
There was a problem hiding this comment.
There two files are moved into the SchemaDownload Xcode folder - it's the only place they're needed.
designatednerd
approved these changes
Oct 26, 2021
calvincestari
added
the
codegen
|
Once #1999 is merged I'll fix the merge conflicts. It's a good blocker on this for now to prevent accidental merging. |
Base automatically changed from
1.0/refactor-filemanager-extension
to
release/1.0-alpha-incubating
October 29, 2021 21:04
calvincestari
force-pushed
the
1.0/goodbye-cli
branch
from
39b35ab
to
379b1d8
Compare
|
This is now rebased and will be merged ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2001
This PR is branched off of PR #1999 but I do not intend to merge it into that branch. Once the parent PR (#1999) is merged GitHub should automagically change the base branch to
release/1.0-alpha-incubatingwhich is the intended target.On to the business of this PR:
ApolloCodegenConfigurationanyways so I'll put that into a different PR, together with a couple other related bits.Goodbye CLI, it's been grand, you can see yourself out now - Totsiens, Au Revoir, Auf Wiedersehen, Yasou, Aloha, Namaste, Arrivederci, Sayōnara, Adios, Hamba kahle, Do pobachennia!