-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow output of schema.json from ApolloCodegenLib #2155
Comments
Thanks for raising this discrepancy @bdrelling - is the issue that you actually need json output or that the guide is incorrect The guide is easy enough to fix but we specifically selected SDL output because it is vastly more human-readable than the json output. If json output is what you need I'm interested in learning more of your use-case to understand that need better. |
I'n not sure if the guide is incorrect, it mentions We're fine using the SDL / In terms of readability, that is something we discussed on my team as well--I think many of us find the JSON much more readable, but it could just be because we're not used to seeing the SDL output. |
Fair comment, by "incorrect" I mean that the guide isn't matching what the code does which I take to be the source of truth. I'll get the docs updated to match.
With the merging of #1935 apollo-cli is no longer used for schema downloading, and the 1.0 branches don't use apollo-cli at all, #2003 removed it completely.
I've created #2159 where we can track the final decision to add a config option for json output. |
Feature request
Allow output of
schema.json
instead ofschema.graphqls
viaApolloCodegenLib
usage.Motivation
Attempting to follow the Swift scripting guide. We use
schema.json
explicitly, but the output only works asschema.graphqls
.Proposed solution
That the tool allows selection between
graphqls
orjson
output. If it currently does, I cannot figure out how via docs or code exploration. The guide seems to implyschema.json
can be used.Outstanding Questions
The text was updated successfully, but these errors were encountered: