Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that user-provided context is lost if skip is toggled #7582

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/react/data/QueryData.ts
Original file line number Diff line number Diff line change
Expand Up @@ -484,6 +484,9 @@ export class QueryData<TData, TVariables> extends OperationData {
private removeObservable(andDelete: boolean) {
if (this.currentObservable) {
this.currentObservable["tearDownQuery"]();
// this.currentObservable.options.context is deleted in tearDownQuery(),
// so we also delete the context from this.previous.observableQueryOptions
delete this.previous.observableQueryOptions.context;
if (andDelete) {
delete this.currentObservable;
}
Expand Down