Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug that user-provided context is lost if skip is toggled #7582

Closed
wants to merge 1 commit into from

Conversation

chochihim
Copy link

I am not sure if this is the best fix and how test should be added for this case. Let me know and I can change the code accordingly.

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests

@apollo-cla
Copy link

@chochihim: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@benjamn
Copy link
Member

benjamn commented Feb 15, 2021

@chochihim We ended up reverting the deletion of observableQuery.options.context in tearDownQuery in #7695. Is this change still relevant now?

@benjamn benjamn added the 🏓 awaiting-contributor-response requires input from a contributor label Feb 15, 2021
@chochihim
Copy link
Author

It should be fine now. I will open another issue if I still encounter my problem using the latest version.

@chochihim chochihim closed this Feb 16, 2021
@chochihim chochihim deleted the patch-1 branch February 16, 2021 02:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🏓 awaiting-contributor-response requires input from a contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants