Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feaure/unique proxy backend base paths #1603

Closed
wants to merge 12 commits into from

Conversation

55
Copy link
Contributor

@55 55 commented Sep 19, 2016

Closes #1200

@55 55 added the in progress label Sep 19, 2016
@brylie brylie self-assigned this Sep 21, 2016
@55 55 added this to the Sprint 31 milestone Sep 21, 2016
@55
Copy link
Contributor Author

55 commented Sep 23, 2016

Maybe fb21892 is unnecessary.

@brylie please test and review.

@brylie
Copy link
Contributor

brylie commented Sep 23, 2016

This does not seem to give any validation message when a duplicate 'frontend_prefix' is used.

@bajiat bajiat modified the milestones: Sprint 32, Sprint 31 Sep 26, 2016
@55
Copy link
Contributor Author

55 commented Sep 27, 2016

Still can't save API Proxy backend.
@apinf/developers if anyone has time to help me with this.

A check for uniqueness works but in some cases can't submit the form.

@brylie
Copy link
Contributor

brylie commented Sep 29, 2016

I am getting duplicate key errors, perhaps related to data sync from nightly.umbrella.apinf.io.

@brylie
Copy link
Contributor

brylie commented Sep 29, 2016

I cleaned up nightly.umbrella.apinf.io and configured a local instance of Apinf.

When trying to add a new Proxy Backend, the Disable API Key field appears to malfunction (in Firefox 50.0a2):

screenshot from 2016-09-29 10-34-11

Perhaps start a fresh branch from the latest develop, and add your changes there.

@brylie
Copy link
Contributor

brylie commented Sep 29, 2016

I am able to add a Proxy Backend from Chromium, so we seem to have a Firefox bug related to the Disable API Key field.

@brylie
Copy link
Contributor

brylie commented Sep 29, 2016

The uniqueness check appears to work in Chromium browser, but there is no User Interface message. I see this in the Chromium console:

errorClass {error: 409, reason: "WriteError({"code":11000,"index":0,"errmsg":"E1100…-aa49-40363121cf57"},"_id":"baahyt4AK9w5f9k3L"}})", details: undefined, message: "WriteError({"code":11000,"index":0,"errmsg":"E1100…40363121cf57"},"_id":"baahyt4AK9w5f9k3L"}}) [409]", errorType: "Meteor.Error"}
details: undefined
error: 409
errorType: "Meteor.Error"
message: "WriteError({"code":11000,"index":0,"errmsg":"E11000 duplicate key error collection: meteor.proxyBackends index: frontend_prefix_1 dup key: { : null }","op":{"proxyId":"qPDcJkDmLbJbBxYf7","apiId":"DRsTjo7vbEeHAWK3a","apiUmbrella":{"name":"Google 2","frontend_host":"nightly.umbrella.apinf.io","backend_host":"google.com","backend_protocol":"http","servers":[{"host":"google.com","port":80}],"balance_algorithm":"least_conn","url_matches":[{"frontend_prefix":"/google/","backend_prefix":"/"}],"settings":{"disable_api_key":false},"id":"49f65fad-518e-41b9-aa49-40363121cf57"},"_id":"baahyt4AK9w5f9k3L"}}) [409]"
reason: "WriteError({"code":11000,"index":0,"errmsg":"E11000 duplicate key error collection: meteor.proxyBackends index: frontend_prefix_1 dup key: { : null }","op":{"proxyId":"qPDcJkDmLbJbBxYf7","apiId":"DRsTjo7vbEeHAWK3a","apiUmbrella":{"name":"Google 2","frontend_host":"nightly.umbrella.apinf.io","backend_host":"google.com","backend_protocol":"http","servers":[{"host":"google.com","port":80}],"balance_algorithm":"least_conn","url_matches":[{"frontend_prefix":"/google/","backend_prefix":"/"}],"settings":{"disable_api_key":false},"id":"49f65fad-518e-41b9-aa49-40363121cf57"},"_id":"baahyt4AK9w5f9k3L"}})"

Also, the form fields are reset when this error occurs.

illya added 2 commits October 3, 2016 07:08
# Conflicts:
#	proxy_backends/collection/apiUmbrellaSchema.js
@55
Copy link
Contributor Author

55 commented Oct 10, 2016

Closing this. New PR #1722

@55 55 closed this Oct 10, 2016
@55 55 removed the in progress label Oct 10, 2016
@55 55 deleted the feature/check-unique-apibackend branch October 10, 2016 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants