Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow only unique proxy backend base paths #1200

Closed
2 tasks done
bajiat opened this issue Jun 22, 2016 · 6 comments
Closed
2 tasks done

Allow only unique proxy backend base paths #1200

bajiat opened this issue Jun 22, 2016 · 6 comments
Assignees
Milestone

Comments

@bajiat
Copy link
Contributor

bajiat commented Jun 22, 2016

In order to avoid having the same API added to the catalog more than once, we should only allow unique API backends. (As a follow-up, we may need to give an option to API owners to report, if someone else have added their API)

Definition of done

  • User can only add an API with Add API Wizard, if the front-end prefix (proxy backend base path) is unique?
  • If the user tries to add a pre-existing URL (with pre-existing frontend prefix?), they get an error saying that this API backend already exists.
@55
Copy link
Contributor

55 commented Jun 23, 2016

Interested in this task.

@bajiat
Copy link
Contributor Author

bajiat commented Jun 30, 2016

Check also: NREL/api-umbrella#252

@Nazarah
Copy link
Contributor

Nazarah commented Jul 1, 2016

I will add warning messages here

@55 55 self-assigned this Jul 18, 2016
@55 55 added planning and removed backlog labels Jul 18, 2016
@55 55 added this to the Sprint 27 milestone Jul 18, 2016
@55 55 added ready and removed planning labels Jul 19, 2016
@55 55 added in progress and removed ready labels Jul 19, 2016
@bajiat bajiat added the blocked label Aug 8, 2016
@brylie brylie modified the milestones: Sprint 28, Sprint 27 Aug 10, 2016
@bajiat bajiat unassigned 55 Aug 15, 2016
@bajiat bajiat modified the milestones: Sprint 29, Sprint 28 Aug 15, 2016
@bajiat bajiat removed the planning label Aug 15, 2016
@bajiat bajiat added the ready label Aug 15, 2016
@jykae
Copy link
Contributor

jykae commented Aug 15, 2016

Depends on #1379

Discussed with @brylie that we will deprecate autoform-wizard package and use simple autoform for adding API. Number of fields (4 fields) without proxy related fields will be ok for one page form.

@jykae
Copy link
Contributor

jykae commented Aug 15, 2016

@bajiat @brylie I assume it is "API base URL" that should be unique? Do we want to support versioning of API?
For example: api.test.com/v1/ and api.test.com/v2/ Can I add those as one API or do I need to add version 2 as a separate API?

@brylie
Copy link
Contributor

brylie commented Aug 15, 2016

The frontend_prefix is the field that needs to be unique. This is because Proxy API Backends that share frontend prefixes will 'collide' with one another.

@brylie brylie added blocked and removed ready labels Aug 16, 2016
@bajiat bajiat unassigned jykae Sep 9, 2016
@bajiat bajiat added planning and removed blocked labels Sep 9, 2016
@bajiat bajiat changed the title Allow only unique API backend URL's Allow only unique proxy backend base paths Sep 9, 2016
@bajiat bajiat added ready and removed planning labels Sep 13, 2016
@55 55 modified the milestones: Sprint 31, Sprint 29 Sep 19, 2016
@55 55 added in progress and removed ready labels Sep 19, 2016
@bajiat bajiat modified the milestones: Sprint 32, Sprint 31 Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants