Client and Plan support #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rework contributed code to conform to existing standards.
|
@outofcoffee Any idea which branch I should work against? Also just noticed a few bits I need to zap before merging, but please have a play and see if it works for you. |
|
Declarative bits that are missing will be committed shortly |
|
Now I can see that the CLI needs a couple of extra commands adding to enable plans to be added to APIs (i.e. non declarative) |
|
@pcornish what is your philosophy when it comes to error handling? For example, at the moment with certain list commands you just get an ugly exception. My thoughts are that we could parse the returned JSON and display the canonical message? What do you think. Or is this already meant to happen? e.g. vs (mocked up example) -- something better than a huge trace. I'm still not quite clear whether this is meant to be happening but it's b0rked or we should be relying on CLI-side validation (which seems a lot of work and maintenance in this circumstance). |
Behaviour seemed to have changed for some reason, so took opportunity to align dependencies with Apiman main project use the ser/deser feature to fix. Signed-off-by: Marc Savy <[email protected]>
Signed-off-by: Marc Savy <[email protected]>
|
Okay, was having an issue that turns out to be related to a bug in Maven 3.5.0's snapshot metadata. Will be pushing some more changes shortly, hopefully. |
Signed-off-by: Marc Savy <[email protected]>
Signed-off-by: Marc Savy <[email protected]>
Signed-off-by: Marc Savy <[email protected]>
Signed-off-by: Marc Savy <[email protected]>
|
@pcornish I think your recent "exception cause" changes on apiman/apiman may have had an unintended side-effect of breaking the apiman-cli tests -- as some exceptions that were 404 are now showing as 500s. Investigating! |
|
Reference for the above d9f95c2990f01197152c5d5f3ed855aca1ea5bc9 |
Signed-off-by: Marc Savy <[email protected]>
Signed-off-by: Marc Savy <[email protected]>
|
Hi @msavy. On latest master (e35c0f0) and develop (776a17e) the tests look OK. Here are the steps I ran (straight from the travis config file): If you have some specific tests you want me to look at let me know and I'll happily take a look. |
|
@pcornish I reverted a PR on apiman/apiman itself as it was causing the unintended side-effects. |
|
Ah yes, sorry, I did see that :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked jquantins work, but excluded the deepList stuff which needs some additional discussion.