add multi-gateways support to api command and plan support to declarative command #24
Conversation
… run commands. Reorganises command package structure. Factors out declarative application logic into separate services. Improves docs.
| @@ -62,6 +67,9 @@ | |||
| @Option(name = "--gateway", aliases = {"-g"}, usage = "Gateway") | |||
There was a problem hiding this comment.
Can we make the gateway argument a List<String>? Args4j will do the rest.
There was a problem hiding this comment.
ok I remove the "gateways" arg and make the "gateway" one, being a List (can occurs more than once)
for instance : "-g gw1 -g gw2"
| @@ -81,11 +89,23 @@ public void performAction(CmdLineParser parser) throws CommandException { | |||
| description, | |||
| initialVersion); | |||
|
|
|||
| final List gatewaysList = Lists.newArrayList(); | |||
There was a problem hiding this comment.
This won't be needed anymore if we make the private field a List<String>
There was a problem hiding this comment.
I steel use it for creating a list of GatewayApi Objects
| * Never clone a previous version when creating a new version. | ||
| */ | ||
| @JsonProperty | ||
| final private boolean clone = false; |
There was a problem hiding this comment.
Is this needed for plan creation?
There was a problem hiding this comment.
Yes it works like the POST of api's version (@post("/organizations/{orgName}/plans/{planName}/versions")
The clone's mecanism is the same as Api one.
EricWittmann
changed the title
|
Hi @jquantin I haven't forgotten about this. As soon as my main PR is resolved, I'll be looking to get your work in (I'll refactor it). |
|
Cool ! Thank-you |
|
Hey @jquantin is the branch you reference (OrgAPI) still the latest? Looking to merge in your work on my branch. |
|
Hi, |
outofcoffee
force-pushed
the
develop
branch
2 times, most recently
from
0519fd7 to
5ab5ce9
Compare
|
Superseded by #36 |
Hi,
This is 2 things :
I only add a new param "gateways" (with a s) and let the old one "gateway" (without s) to be sure to not break things. I can merge the 2 params together (the one without s) if its preferable.
thanks