Resolve TODOs #84
Merged
Resolve TODOs #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siegrift
commented
Nov 9, 2023
Siegrift
force-pushed
the
resolve-todos
branch
from
2e0c6da
to
246ad25
Compare
Siegrift
force-pushed
the
resolve-todos
branch
from
246ad25
to
36dff4b
Compare
ah yes, I separately realised that yesterday and updated it in my branch, whoops 🙈 |
aquarat
approved these changes
Nov 10, 2023
vponline
approved these changes
Nov 10, 2023
Siegrift
force-pushed
the
resolve-todos
branch
from
6cc7dc4
to
5a50dbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77
Rationale
Each TODO is fixed in a separate commit for easier reviews. I recommend reviewing commit by commit.
I updated the diagram and exported the white background version. I don't remember the issues we had with it, but it seems correctly rendered to me. Let me know if I should change it back to black.
I also realized that the logic for determining updating beacon sets was wrong (we need to get data for constituent beacons and then use median for checks). I've updated the logic and created #83.