Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deep beacon set update check #75

Closed
wants to merge 11 commits into from
Closed

Deep beacon set update check #75

wants to merge 11 commits into from

Conversation

aquarat
Copy link
Collaborator

@aquarat aquarat commented Nov 7, 2023 •
edited
Loading

This PR:

  • Starts by executing the existing shallow beacon set check based on the datafeed's value returned from the chain during the batch call.
  • For all feeds appearing to need an update it when reads the latest values of the children of those feeds and does two timestamp checks to confirm the feeds are indeed updatable.
  • Child feeds that are not updatable have their on chain values used in a second/follow-up threshold assessment. If during that check the calcualted values don't exceed the deviation threshold the feeds are not updated.
  • Lastly, updatable child feeds are propagated to the updateFeeds function such that those feeds are not updated during the batch.

This PR also fixes a bug that PR #84 addresses, so will result in some merge conflicts.

Closes #67

@aquarat aquarat self-assigned this Nov 8, 2023
@aquarat aquarat changed the title [Draft] Initial deep beacon set update check Initial deep beacon set update check Nov 8, 2023
Siegrift
Siegrift requested changes Nov 8, 2023
View reviewed changes
src/update-feeds/update-feeds.ts Outdated Show resolved Hide resolved
src/update-feeds/update-feeds.ts Outdated Show resolved Hide resolved
@aquarat aquarat changed the title Initial deep beacon set update check Deep beacon set update check Nov 9, 2023
@aquarat aquarat marked this pull request as ready for review November 10, 2023 17:21
Siegrift
Siegrift reviewed Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@Siegrift Siegrift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase please?

@aquarat aquarat mentioned this pull request Nov 15, 2023
Merged
@aquarat
Copy link
Collaborator Author

aquarat commented Nov 15, 2023 •
edited
Loading

Closing as rebasing was far too complex.

Refer to replacement here: #95

@aquarat aquarat closed this Nov 15, 2023
@aquarat aquarat reopened this Nov 15, 2023
@aquarat aquarat closed this Nov 15, 2023
@Siegrift Siegrift deleted the 67-deep-check-child-beacons branch November 22, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siegrift Siegrift Siegrift requested changes

@vponline vponline Awaiting requested review from vponline

Assignees

@aquarat aquarat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check which beacons of a beacon set need to be updated
2 participants
@aquarat @Siegrift