Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix arbitrum getBlockNumber #256

Merged
merged 2 commits into from
Apr 18, 2024
Merged

Fix arbitrum getBlockNumber #256

merged 2 commits into from
Apr 18, 2024

Conversation

Siegrift
Copy link
Collaborator

@Siegrift Siegrift self-assigned this Apr 18, 2024
bdrhn9
bdrhn9 approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@bdrhn9 bdrhn9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But as @bbenligiray said here, it's better to have arbitrum-sepolia-testnet.

@Siegrift
Copy link
Collaborator Author

But as @bbenligiray said here, it's better to have arbitrum-sepolia-testnet.

Yep. Added that as well.

@Siegrift Siegrift merged commit 8054ce0 into main Apr 18, 2024
4 checks passed
@Siegrift Siegrift deleted the arbitrum-hotfix branch April 18, 2024 12:08
@Siegrift Siegrift mentioned this pull request Apr 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdrhn9 bdrhn9 bdrhn9 approved these changes

@bbenligiray bbenligiray Awaiting requested review from bbenligiray

Assignees

@Siegrift Siegrift

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Siegrift @bdrhn9