-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make getting block number from RPC instead of contract configurable #273
Comments
With this, airseeker-admin (and the self-funded Nodary Airseeker, and whoever else will use Airseeker) will need to keep a list of chains for which it should enable this in the config, so operationally we will end up having a very similar thing + a more complex config. I think we should just maintain a list of chain IDs hardcoded in Airseeker and patch it as we need to add new chains, and abstract this away from the user. |
Maybe this should be something in the @api3/chains repo? Aka some flag optional flag that all the packages can consume. |
So a script that determines this automatically in the chains repo? That way these properties can be autogenerated there. Shall we create an issue in the chains repo for this? |
I created api3dao/chains#264 and api3dao/chains#265 but I think getting api3dao/chains#264 right is important and we'll need some help from @bdrhn9 about that |
I'm adding "blocked" label until this is implemented in chains. |
See: #314 (comment) We are not always fetching the block number from the RPC. |
See: #256
There are some chains (arbitrum) for which
block.number
doesn't work as expected.This should be made configurable.
The text was updated successfully, but these errors were encountered: