Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make getting block number from RPC instead of contract configurable #273

Closed
Siegrift opened this issue Apr 26, 2024 · 7 comments
Closed
Labels
blocked Blocked by something

Comments

@Siegrift
Copy link
Collaborator

Siegrift commented Apr 26, 2024

See: #256

There are some chains (arbitrum) for which block.number doesn't work as expected.

This should be made configurable.

@bbenligiray
Copy link
Member

With this, airseeker-admin (and the self-funded Nodary Airseeker, and whoever else will use Airseeker) will need to keep a list of chains for which it should enable this in the config, so operationally we will end up having a very similar thing + a more complex config. I think we should just maintain a list of chain IDs hardcoded in Airseeker and patch it as we need to add new chains, and abstract this away from the user.

@Siegrift
Copy link
Collaborator Author

Maybe this should be something in the @api3/chains repo? Aka some flag optional flag that all the packages can consume.

@bbenligiray
Copy link
Member

Maybe the same applies to gas cost/gas limit stuff that @bdrhn9 has to handle on a chain by chain basis in logdata-miner. Maybe there should be script that one runs to determine these properties automatically @hiletmis .

@Siegrift
Copy link
Collaborator Author

So a script that determines this automatically in the chains repo? That way these properties can be autogenerated there.

Shall we create an issue in the chains repo for this?

@bbenligiray
Copy link
Member

I created api3dao/chains#264 and api3dao/chains#265 but I think getting api3dao/chains#264 right is important and we'll need some help from @bdrhn9 about that

@Siegrift
Copy link
Collaborator Author

I'm adding "blocked" label until this is implemented in chains.

@Siegrift
Copy link
Collaborator Author

See: #314 (comment)

We are not always fetching the block number from the RPC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by something
Projects
None yet
Development

No branches or pull requests

2 participants