feat(node): expose endpointParameters to all pre/post-processing steps #1831
Conversation
|
The description looks good, I'll review as soon as possible |
| // provide endpoint parameters immutably | ||
| let endpointParameters = JSON.parse(JSON.stringify(payload.aggregatedApiCall.parameters)); | ||
|
|
||
| // The HTTP gateway is a special case for ChainAPI that is not allowed to access reserved parameters |
There was a problem hiding this comment.
Sorry, I remember writing about this but I couldn't find where, but it may have been vague.
- We want both pre-processing and post-processing to not have access to the reserved parameters (this seems to only do it for post-processing)
- This should apply to all cases, and not only calls coming through the gateway. The reasoning is that breaking some old endpoints that use reserved parameters in processing (which to my knowledge don't exist) is preferable to endpoints potentially behaving differently when used in different ways.
There was a problem hiding this comment.
We want both pre-processing and post-processing to not have access to the reserved parameters
OK, I've removed access to reserved parameters from pre- and post-processing.
This should apply to all cases, and not only calls coming through the gateway.
The title and description of #1738 was specific for the gateway (because of ChainAPI test calls) and so that is what I addressed in #1794. But easy enough and makes sense. I've made the change.
There was a problem hiding this comment.
Right, I now realize that that is about an older PR. @andreogle for visibility I guess 😅 The fix looks good, thanks.
- make endpointParameters immutable between processing steps - remove access to reserved parameters from pre/post-processing regardless of API call type
Closes #1673.
I implemented this by passing
endpointParametersto the VM context inunsafeEvaluateandunsafeEvaluateAsyncfor both pre- and post-processing. This allows the endpointParameters to be immutable with respect to theparametersof theaggregatedApiCall(more relevant to pre-processing).Note to achieve the above immutability and to avoid breaking existing post-processing code, I did not modify the
input(the raw API call response data) of thereduceofpostProcessingSpecifications.