Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unexported-airnode-features #79

Closed
metobom opened this issue Oct 10, 2023 · 4 comments · Fixed by #75
Closed

Update unexported-airnode-features #79

metobom opened this issue Oct 10, 2023 · 4 comments · Fixed by #75
Milestone

Comments

@metobom
Copy link
Member

metobom commented Oct 10, 2023

Pusher uses an old version of processing for pre/post-processing under unexported-airnode-features folder. We need this feature from Airnode 0.12.0.

Possibly related to #77

@metobom metobom added this to the v0.1 milestone Oct 10, 2023
@bbenligiray
Copy link
Member

@Siegrift we can just do this to avoid having the v0.1 release be blocked by #77

@Siegrift
Copy link
Collaborator

I can finish api3dao/commons#9 which we can then release and then merge #75.

I think we can do the above tomorrow, so that should be fine?

@bdrhn9
Copy link
Contributor

bdrhn9 commented Oct 11, 2023

Fwiw, in the concept implementation I created this pre/post functions externally not for they are unexported but to implement requested feature. It's here paremeters are also passed to post-processing (current one here). So, the example config generated by Nodary won't work because we are leveraging parameters in post processing, see https://github.com/api3dao/signed-api/blob/main/packages/pusher/config/pusher.example.json#L82.

@Siegrift
Copy link
Collaborator

Yeah, but this was later already implemented in Airnode. You can see that the pusher config the same as the Nodary one and I checked that it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants