Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy protocol contracts on new chains #1562
Deploy protocol contracts on new chains #1562
Changes from 14 commits
acaea95
d78ffba
3bca1b1
a6ec97b
6beac7f
4f054db
02027bd
f9645b1
2d2a3ec
ddfd98e
29675ca
a709c80
b681038
9186b6b
5f06d50
b7cc6c4
83cdb28
0174652
b0ad766
86c534a
1b174c1
038c49c
16445f5
4ccf2f2
145c0d2
d1d1bef
26494ab
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added but I'm seeing that the contracts are not verified on https://aurorascan.dev/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hardhat does support aurora but when I try to run the verify command I get the following error:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The contracts do get verified locally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had all previous deployments verified on the etherscan/blockscout block explorers manually. You can find the flattened versions at ftmscan.com or flatten them yourself using
hardhat flatten
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is needed for decoding of transactions and in the etherscan case to allow the user interact with the contract over etherscan, it's not necessarily about verification that the contract is correct (that's what deterministic deployments and
verify-local
are for).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use kebab-case here and in the directory names. So
boba-avalanche
,boba-bnb
, etc. so that we can standardize this #1575